[CI] Added codecov component for package#2422
Closed
unity-nikos wants to merge 1 commit into
Closed
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
I have completed the review of this Pull Request. The changes look very solid overall, with only one minor configuration issue identified in the Codecov settings.
Summary of Findings
- Codecov Schema Compliance: Identified a minor issue in
.github/codecov.ymlwherecomponent_idwas used instead ofidfor identifying a component.
🤖 Helpful? 👍/👎
| # Components configuration | ||
| component_management: | ||
| individual_components: | ||
| - component_id: "com.unity.inputsystem" |
Contributor
There was a problem hiding this comment.
According to the Codecov configuration schema, individual components use id as the key to specify their unique identifier, rather than component_id. Using component_id may cause Codecov to fail to validate or properly recognize this component.
Suggested change
| - component_id: "com.unity.inputsystem" | |
| - id: "com.unity.inputsystem" |
🤖 Helpful? 👍/👎 by guardian
Collaborator
Author
|
Closing — will re-open from a branch on the main repo instead of a fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
See Configure packages as components