[TS] Normalize conditional operands before string concatenation - #392
Merged
CaelmBleidd merged 1 commit intoSep 22, 2026
Conversation
CaelmBleidd
deleted the
caelmbleidd/fix-ts-conditional-string-concat
branch
September 22, 2026 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbolic string indexing can produce a conditional
char | undefinedreference. String concatenation queried its type before applying JavaScript coercion, allowing anITE(ref, null)expression to reach model extraction and fail withUnexpected ref.Normalize conditional operands branchwise before type lookup and convert concrete nullish values to their JavaScript string representations. Type constraints and witness extraction remain unchanged.
This PR depends on #391.
Validation:
./gradlew :usvm-ts:test :usvm-ts-calls:test --no-daemonCurrentTsCallsSymbolicEngineTestgit diff --check