implement recursive search for GOES products across hour boundaries#3862
implement recursive search for GOES products across hour boundaries#3862migratesky wants to merge 7 commits intoUnidata:mainfrom
Conversation
|
Krishna seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi, thanks for your PR! This will be super helpful. We'll open some PRs that will help us with some of the unrelated test issues. I have some general feedback that we would need in this functionality before a detailed code review:
AssertionError: assert '.../OR_ABI-L1b-RadM2-M6C01_G18_s20250092355554_e20250092356011_c20250092356044.nc' == '.../OR_ABI-L1b-RadM1-M6C02_G18_s20250092356254_e20250092356311_c20250092356338.nc'
I hope this gives you some direction, let me know if we can answer any additional questions. Looking forward to it! |
| if best_diff is None or diff < best_diff: | ||
| best_obj = obj | ||
| best_diff = diff | ||
| except (ValueError, IndexError): |
Check notice
Code scanning / CodeQL
Empty except Note
| if best_diff is None or diff < best_diff: | ||
| best_obj = obj | ||
| best_diff = diff | ||
| except (ValueError, IndexError): |
Check notice
Code scanning / CodeQL
Empty except Note
|
@dcamron |
|
We will get this reviewed soon for our planned v1.8.0 release this Fall. Thanks! |
Checklist