Skip to content

style: allow @angular-eslint/template/alt-text-error rule #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ert78gb merged 1 commit into from
Aug 5, 2026
Merged

style: allow @angular-eslint/template/alt-text-error rule #3043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/uhk-web/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export default tsEslint.config(
...angular.configs.templateAccessibility,
],
rules: {
'@angular-eslint/template/alt-text': 'off',
'@angular-eslint/template/click-events-have-key-events': 'off',
'@angular-eslint/template/elements-content': 'off',
'@angular-eslint/template/interactive-supports-focus': 'off',
Expand Down
3 changes: 0 additions & 3 deletions packages/uhk-web/src/app/components/popover/tab/keymap/keymap-tab.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
</ng-select>
</div>
<div class="keymap-container">
<div class="empty" *ngIf="!selectedKeymap?.abbreviation">
<img src="assets/images/base-layer--blank.svg">

@ert78gb ert78gb Aug 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have this asset so I dropped the whole outer element.
I tried to test it with manually modify the user config but it not loading if the config is invalid. so as I see it was a dead branch

</div>
<svg-keyboard *ngIf="selectedKeymap?.abbreviation"
[moduleConfig]="selectedKeymap.layers[0].modules"
[embedded]="true"
Expand Down
11 changes: 0 additions & 11 deletions packages/uhk-web/src/app/components/popover/tab/keymap/keymap-tab.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,3 @@
padding: 1rem;
background-color: var(--color-keymap-tab-background);
}

.empty {
display: flex;

img {
display: flex;
width: 100%;
height: 100%;
position: relative;
}
}
5 changes: 5 additions & 0 deletions packages/uhk-web/src/app/store/reducers/calculate-layer-options-of-keymap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import { initLayerOptions } from './layer-options';
export function calculateLayerOptionsOfKeymap(keymap: Keymap): Map<number, LayerOption> {
const layerOptions = initLayerOptions();

// it can happen when the user changes the URL to invalid keymap abbreviation
if (!keymap) {
return layerOptions;
}

for (const layer of keymap.layers) {
layerOptions.get(layer.id).selected = true;
}
Expand Down
Loading