Repository navigation
Conversation
github-actions
Bot
added
test:uipath-langchain
A connection reset during the TLS handshake raised httpx.ConnectError, which the platform retry did not cover, so one dropped connection failed the whole call. A failed connect never sends the request, so it is safe to retry for any method. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXskDkqHWRWgUhAzNk7ptY
16a613c to
3e96a2b
Compare
Epixa-Dogfood ReviewReview unavailable: Not reviewed: What this PR doesThe pull request author describes the intended change as follows: fix(platform): retry requests that fail to connect This review did not reuse a local review of this change. Set up Epixa local review. Full review: 3e96a2b |
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation and regression test correctly extend existing retry behavior without retrying post-connection transport errors.
0 open findings
What changed in this PR
Adds retries for transient httpx.ConnectError failures in the platform HTTP client.
Changes:
- Marks connection failures as retryable.
- Adds a focused regression test.
- Bumps
uipath-platformto 0.2.37.
| File | Description |
|---|---|
packages/uipath-platform/src/uipath/platform/common/retry.py |
Adds ConnectError to retryable exceptions. |
packages/uipath-platform/tests/services/test_retry.py |
Tests connection-error classification. |
packages/uipath-platform/pyproject.toml |
Bumps the package version. |
packages/uipath-platform/uv.lock |
Updates locked package metadata. |
packages/uipath/uv.lock |
Updates the consuming package’s lock metadata. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🚨 Heads up:
|
|
🚨 Heads up:
|
What broke: sometimes the network drops a connection while it is still being opened. One dropped connection made the whole step fail.
The fix: treat
httpx.ConnectErroras something to retry, with the same backoff and attempt limit as timeouts.Why this is safe: a
ConnectErrormeans the request never left our side, because the connection wasn't up yet. Sending it again can't do anything twice, even for a POST. Errors that can happen after the server already got the request (ReadError,WriteError) are still not retried.