fix: resolve real bedrock backing model for BYO aliases in factory#103
Open
andreiancuta-uipath wants to merge 1 commit into
Open
fix: resolve real bedrock backing model for BYO aliases in factory#103andreiancuta-uipath wants to merge 1 commit into
andreiancuta-uipath wants to merge 1 commit into
Conversation
andreiancuta-uipath
requested review from
DragosBobolea,
cosminacho,
cristipufu,
dragosvelcea,
ionmincu,
ionut-mihalache-uipath,
radu-mocanu and
vldcmp-uipath
as code owners
andreiancuta-uipath
temporarily deployed
to
LLMGW_SETTINGS
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Langchain Bedrock clients try to detect model capabilities, including tool calling, from the model name. BYOM aliases can be anything, so some of them are unrecognized by the client and refuse the tool_call parameter → an error is thrown.
The fix is to detect the vendor from the underlying model name (
customerModelin LLMGW terms) and inject that into the clients.