Skip to content

[codex] Add property panel alerts and errors story#857

Merged
dbacomputer merged 2 commits into
mainfrom
codex/property-panel-errors
Jul 2, 2026
Merged

[codex] Add property panel alerts and errors story#857
dbacomputer merged 2 commits into
mainfrom
codex/property-panel-errors

Conversation

@dbacomputer

@dbacomputer dbacomputer commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds an Alerts and Errors Storybook variant for the Node Property Panel.
  • Demonstrates tab-level error counts, inline code-editor validation, and tab-specific section errors for Parameters, Error handling, and Advanced.
  • Places the alert/error pattern notes in a left-side review rail beside the panel preview so designers and engineers can review the guidance and UI together.

Why

This provides a focused design-review surface for validating how users discover where errors live in a property panel and what action they should take next.

Validation

  • node_modules/.bin/tsc --noEmit --project packages/apollo-react/tsconfig.json
  • ../../node_modules/.bin/biome check src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx
  • Refreshed Storybook preview at /story/apollo-react-canvas-components-panels-node-property-panel--alerts-and-errors

Copilot AI review requested due to automatic review settings June 26, 2026 14:09
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jun 26, 2026, 01:28:11 PM
apollo-docs 🟢 Ready Preview, Logs Jun 26, 2026, 01:28:11 PM
apollo-landing 🟢 Ready Preview, Logs Jun 26, 2026, 01:28:11 PM
apollo-vertex 🟢 Ready Preview, Logs Jun 26, 2026, 01:28:11 PM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1945 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1715
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an “Alerts and Errors” Storybook variant for the canvas Node Property Panel to support design review of panel-level and tab-level validation/issue-discovery patterns.

Changes:

  • Extends the existing CasePanel story UI to support inline error styling and an inline validation message.
  • Adds a new Alerts and Errors story variant with an issue summary, per-tab issue counts, and tab-scoped error blocks.
  • Updates HierarchicalCanvas to import BaseNode from a direct module path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/apollo-react/src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx Adds the new “Alerts and Errors” story variant plus supporting UI helpers and error styling in the story panel content.
packages/apollo-react/src/canvas/components/HierarchicalCanvas/HierarchicalCanvas.tsx Adjusts the BaseNode import to use ../BaseNode/BaseNode.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 34.6% 0.0% (0/45) 7.27 MB 27.58 MB +86 B
@uipath/apollo-wind 40.1% 392.4 KB 2.55 MB +13 B
@uipath/ap-chat 85.8% 43.41 MB 55.85 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@dbacomputer dbacomputer force-pushed the codex/property-panel-errors branch from 52ec7bc to acbe729 Compare June 26, 2026 19:20
Copilot AI review requested due to automatic review settings June 26, 2026 19:24
@dbacomputer dbacomputer force-pushed the codex/property-panel-errors branch from acbe729 to e08cff4 Compare June 26, 2026 19:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@dbacomputer dbacomputer force-pushed the codex/property-panel-errors branch from e08cff4 to 25d5ef6 Compare June 26, 2026 19:31
Copilot AI review requested due to automatic review settings June 26, 2026 20:09
@dbacomputer dbacomputer force-pushed the codex/property-panel-errors branch from 25d5ef6 to 1593c90 Compare June 26, 2026 20:09
@dbacomputer dbacomputer marked this pull request as ready for review June 26, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@dbacomputer dbacomputer force-pushed the codex/property-panel-errors branch from 1593c90 to 2dabfe0 Compare June 26, 2026 20:24
@dbacomputer dbacomputer merged commit 2c367c2 into main Jul 2, 2026
43 checks passed
@dbacomputer dbacomputer deleted the codex/property-panel-errors branch July 2, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants