[codex] Add property panel alerts and errors story#857
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Adds an “Alerts and Errors” Storybook variant for the canvas Node Property Panel to support design review of panel-level and tab-level validation/issue-discovery patterns.
Changes:
- Extends the existing
CasePanelstory UI to support inline error styling and an inline validation message. - Adds a new
Alerts and Errorsstory variant with an issue summary, per-tab issue counts, and tab-scoped error blocks. - Updates
HierarchicalCanvasto importBaseNodefrom a direct module path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx | Adds the new “Alerts and Errors” story variant plus supporting UI helpers and error styling in the story panel content. |
| packages/apollo-react/src/canvas/components/HierarchicalCanvas/HierarchicalCanvas.tsx | Adjusts the BaseNode import to use ../BaseNode/BaseNode. |
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
52ec7bc to
acbe729
Compare
acbe729 to
e08cff4
Compare
e08cff4 to
25d5ef6
Compare
25d5ef6 to
1593c90
Compare
1593c90 to
2dabfe0
Compare
Summary
Alerts and ErrorsStorybook variant for the Node Property Panel.Why
This provides a focused design-review surface for validating how users discover where errors live in a property panel and what action they should take next.
Validation
node_modules/.bin/tsc --noEmit --project packages/apollo-react/tsconfig.json../../node_modules/.bin/biome check src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx/story/apollo-react-canvas-components-panels-node-property-panel--alerts-and-errors