fix(apollo-react): cost badges are opt-in, not a picker default - #1045
Open
denispetre wants to merge 2 commits into
Open
fix(apollo-react): cost badges are opt-in, not a picker default#1045denispetre wants to merge 2 commits into
denispetre wants to merge 2 commits into
Conversation
…its i18n catalogs Everything a product needs to integrate the shared picker without re-implementing platform behaviour. Driven by Agent Builder's adoption (UiPath/Agents#5858), but none of it is agent-specific. Region mapping moves in. `homeRegion` accepts the raw OMS organization region as PortalShell serves it ("UnitedStates", "Japan") as well as a geography code, so hosts stop maintaining their own tables - the first one already had JP/SG where the gateway uses JA/SI, silently disabling out-of-region chips. GLOBAL resolves to no home region: it is a routing target, not a place an org lives. Modality is a product decision. The picker renders whatever Discovery serves; `modelType` is on the DTO and `isTextGenerationModel` is exported as an opt-in filter. An indexing surface picks embeddings from the same catalog, so excluding them centrally would break it. Only `isBlockedByPolicy` is still dropped unconditionally. Selection resolves by modelId OR modelName - for `value` and for the recommended/preview override lists. Hosts persist names and author those lists from Model Hub config, which also carries names. The picker performs the BYO configuration DELETE itself against api/byo/product/llm-configurations/{id}, a platform route it already holds credentials for, and reports failures with the gateway's own message. `onModelDeleted` lets hosts reconcile what the picker cannot see - chiefly choosing a replacement selection, which stays a product decision. `onDeleteModel` still works as the opt-out, so no consumer breaks. `loadModelPickerMessages(locale)` replaces the 14 literal dynamic imports every host would otherwise hand-write. It cannot be a template-literal import - a consumer's bundler cannot resolve that through the package exports map - and the symptom of getting it wrong reads like a translation bug rather than a bundling one. 104 tests, up from 78. Squashed from nine commits and rebased onto main so the branch carries no merge commits: this repo merges by rebase, and a plain "Merge branch main" commit pushed via Update branch fails commit-message validation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The picker stamped cost-tier chips itself whenever the DTO carried cost data, using hardcoded $1/M and $5/M thresholds. That made a product decision - what counts as expensive - in the design system, where no product could configure it. Its own doc comment said the picker did NOT do this; the code did. The picker now stamps nothing unless the product passes badgesFor. defaultCostTier stays as the example classifier, documented as such - copy it and tune the thresholds, or classify on something else. The pool badge kinds are the shared contract; the classifier is not. 104 tests. The "stamps by default" test is now "does not stamp unless opted in"; badgesFor([]) suppression is its own case. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Apollo Coded App preview deployments are ready.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
Contributor
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
Contributor
Storybook visual diffBaseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs Updated (PT): Aug 12, 2026, 04:43:32 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The picker stamped cost-tier chips itself whenever the DTO carried cost data, using hardcoded $1/M and $5/M thresholds. That made a product decision — what counts as expensive — in the design system, where no product could configure it. Its own doc comment said the picker did NOT do this; the code did.
The picker now stamps nothing unless the product passes
badgesFor.defaultCostTierstays as the example classifier, documented as such — copy it and tune the thresholds, or classify on something else. The pool badge kinds are the shared contract; the classifier is not.104 tests. The "stamps by default" test is now "does not stamp unless opted in";
badgesFor([])suppression is its own case.