Skip to content

Cryptography: move cryptography property metadata to ViewModels and align category visibility defaults [STUD-80610] #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viogroza merged 1 commit into from
Jun 26, 2026
+355 −1,579
Merged

Cryptography: move cryptography property metadata to ViewModels and align category visibility defaults [STUD-80610] #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...ptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptCryptoViewModelBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ protected DecryptCryptoViewModelBase(IDesignServices services) : base(services)
protected void ConfigureAlgorithmAndKeyProperties(ref int orderIndex)
{
Algorithm.IsPrincipal = true;
Algorithm.IsRequired = true;
Algorithm.OrderIndex = orderIndex++;
Algorithm.Category = Resources.Input;
Algorithm.DataSource = DataSourceHelper.ForEnum(
Expand All @@ -105,9 +106,8 @@ protected void ConfigureAlgorithmAndKeyProperties(ref int orderIndex)
orderIndex++;

KeyEncodingString.IsPrincipal = false;
KeyEncodingString.IsVisible = true;
KeyEncodingString.OrderIndex = orderIndex++;
KeyEncodingString.Category = Resources.Input;
KeyEncodingString.Category = Resources.Category_Options_Name;

KeyEncodingString.DataSource = _encodingDataSource;
KeyEncodingString.Widget = new DefaultWidget { Type = ViewModelWidgetType.Dropdown, Metadata = new Dictionary<string, string>() };
Expand All @@ -124,7 +124,6 @@ protected void ConfigureEncodingDropdown(DesignInArgument<string> encodingProper
{
var dataSource = EncodingHelpers.ConfigureEncodingDataSource();
encodingProperty.IsPrincipal = false;
encodingProperty.IsVisible = true;
encodingProperty.OrderIndex = orderIndex++;
encodingProperty.Category = Resources.Input;
encodingProperty.DataSource = dataSource;
Expand All @@ -141,7 +140,6 @@ protected void ConfigureEncodingDropdown(DesignInArgument<string> encodingProper
protected void ConfigureInteropProperties(ref int orderIndex)
{
Format.IsPrincipal = false;
Format.IsVisible = true;
Format.OrderIndex = orderIndex++;
Format.Category = Resources.Input;
Format.DataSource = DataSourceHelper.ForEnum(
Expand Down Expand Up @@ -211,7 +209,7 @@ protected void ConfigureTailProperties(ref int orderIndex)
VerifySignature.IsPrincipal = false;
VerifySignature.IsVisible = false;
VerifySignature.OrderIndex = orderIndex++;
VerifySignature.Category = Resources.Input;
VerifySignature.Category = Resources.Category_Options_Name;
VerifySignature.Widget = new DefaultWidget { Type = ViewModelWidgetType.Toggle };

PublicKeyFilePath.IsPrincipal = false;
Expand Down
51 changes: 48 additions & 3 deletions ...es/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptFileViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,11 @@ protected override void InitializeModel()
ConfigureInteropProperties(ref orderIndex);

OutputFilePath.IsPrincipal = false;
OutputFilePath.IsVisible = true;
OutputFilePath.IsRequired = false;
OutputFilePath.OrderIndex = orderIndex++;
OutputFilePath.Category = Resources.Input;
OutputFilePath.Category = Resources.Category_Options_Name;

Overwrite.IsPrincipal = false;
Overwrite.IsPrincipal = true;
Overwrite.OrderIndex = orderIndex++;
Overwrite.Category = Resources.Category_Options_Name;
Overwrite.Widget = new DefaultWidget { Type = ViewModelWidgetType.Toggle };
Expand All @@ -68,6 +67,8 @@ protected override void InitializeModel()
DecryptedFile.IsPrincipal = false;
DecryptedFile.OrderIndex = orderIndex;
DecryptedFile.Category = Resources.Output;

ConfigurePropertyTexts();
}

private void ConfigureInputFileMenuActions()
Expand All @@ -76,6 +77,50 @@ private void ConfigureInputFileMenuActions()
ApplyInputFileVisibility();
}

private void ConfigurePropertyTexts()
{
InputFile.DisplayName = Resources.Activity_DecryptFile_Property_InputFile_Name;
InputFile.Tooltip = Resources.Activity_DecryptFile_Property_InputFile_Description;
InputFilePath.DisplayName = Resources.Activity_DecryptFile_Property_InputFilePath_Name;
InputFilePath.Tooltip = Resources.Activity_DecryptFile_Property_InputFilePath_Description;
Algorithm.DisplayName = Resources.Activity_DecryptFile_Property_Algorithm_Name;
Algorithm.Tooltip = Resources.Activity_DecryptFile_Property_Algorithm_Description;
Key.DisplayName = Resources.Activity_DecryptFile_Property_Key_Name;
Key.Tooltip = Resources.Activity_DecryptFile_Property_Key_Description;
KeySecureString.DisplayName = Resources.Activity_DecryptFile_Property_KeySecureString_Name;
KeySecureString.Tooltip = Resources.Activity_DecryptFile_Property_KeySecureString_Description;
OutputFilePath.DisplayName = Resources.Activity_DecryptFile_Property_OutputFilePath_Name;
OutputFilePath.Tooltip = Resources.Activity_DecryptFile_Property_OutputFilePath_Description;
KeyEncodingString.DisplayName = Resources.Activity_DecryptFile_Property_KeyEncodingString_Name;
KeyEncodingString.Tooltip = Resources.Activity_DecryptFile_Property_KeyEncodingString_Description;
Format.DisplayName = Resources.Activity_DecryptFile_Property_Format_Name;
Format.Tooltip = Resources.Activity_DecryptFile_Property_Format_Description;
KeyFormat.DisplayName = Resources.Activity_DecryptFile_Property_KeyFormat_Name;
KeyFormat.Tooltip = Resources.Activity_DecryptFile_Property_KeyFormat_Description;
KdfIterations.DisplayName = Resources.Activity_DecryptFile_Property_KdfIterations_Name;
KdfIterations.Tooltip = Resources.Activity_DecryptFile_Property_KdfIterations_Description;
AesKeySize.DisplayName = Resources.Activity_DecryptFile_Property_AesKeySize_Name;
AesKeySize.Tooltip = Resources.Activity_DecryptFile_Property_AesKeySize_Description;
Overwrite.DisplayName = Resources.Activity_DecryptFile_Property_Overwrite_Name;
Overwrite.Tooltip = Resources.Activity_DecryptFile_Property_Overwrite_Description;
ContinueOnError.DisplayName = Resources.Activity_DecryptFile_Property_ContinueOnError_Name;
ContinueOnError.Tooltip = Resources.Activity_DecryptFile_Property_ContinueOnError_Description;
PrivateKeyFilePath.DisplayName = Resources.Activity_DecryptFile_Property_PrivateKeyFilePath_Name;
PrivateKeyFilePath.Tooltip = Resources.Activity_DecryptFile_Property_PrivateKeyFilePath_Description;
Passphrase.DisplayName = Resources.Activity_DecryptFile_Property_Passphrase_Name;
Passphrase.Tooltip = Resources.Activity_DecryptFile_Property_Passphrase_Description;
PassphraseSecureString.DisplayName = Resources.Activity_DecryptFile_Property_PassphraseSecureString_Name;
PassphraseSecureString.Tooltip = Resources.Activity_DecryptFile_Property_PassphraseSecureString_Description;
VerifySignature.DisplayName = Resources.Activity_DecryptFile_Property_VerifySignature_Name;
VerifySignature.Tooltip = Resources.Activity_DecryptFile_Property_VerifySignature_Description;
PublicKeyFilePath.DisplayName = Resources.Activity_DecryptFile_Property_PublicKeyFilePath_Name;
PublicKeyFilePath.Tooltip = Resources.Activity_DecryptFile_Property_PublicKeyFilePath_Description;
PublicKeyFile.DisplayName = Resources.Activity_DecryptFile_Property_PublicKeyFile_Name;
PublicKeyFile.Tooltip = Resources.Activity_DecryptFile_Property_PublicKeyFile_Description;
DecryptedFile.DisplayName = Resources.Activity_DecryptFile_Property_DecryptedFile_Name;
DecryptedFile.Tooltip = Resources.Activity_DecryptFile_Property_DecryptedFile_Description;
}

private void ApplyInputFileVisibility()
{
bool useResource = _inputFileToggle.UseSecondary;
Expand Down
42 changes: 42 additions & 0 deletions ...es/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptTextViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ protected override void InitializeModel()
var orderIndex = 1;

Input.IsPrincipal = true;
Input.IsRequired = true;
Input.OrderIndex = orderIndex++;
Input.Category = Resources.Input;

Expand All @@ -44,6 +45,7 @@ protected override void InitializeModel()
Result.Category = Resources.Output;

ConfigureTailProperties(ref orderIndex);
ConfigurePropertyTexts();
ConfigureKeyInputModeMenuActions();
ConfigurePublicKeyFileMenuActions();
ConfigurePassphraseInputModeMenuActions();
Expand All @@ -53,5 +55,45 @@ protected override void OnAlgorithmChanged(bool isPgp)
{
PlaintextEncodingString.IsVisible = !isPgp;
}

private void ConfigurePropertyTexts()
{
Algorithm.DisplayName = Resources.Activity_DecryptText_Property_Algorithm_Name;
Algorithm.Tooltip = Resources.Activity_DecryptText_Property_Algorithm_Description;
Input.DisplayName = Resources.Activity_DecryptText_Property_Input_Name;
Input.Tooltip = Resources.Activity_DecryptText_Property_Input_Description;
Key.DisplayName = Resources.Activity_DecryptText_Property_Key_Name;
Key.Tooltip = Resources.Activity_DecryptText_Property_Key_Description;
KeySecureString.DisplayName = Resources.Activity_DecryptText_Property_KeySecureString_Name;
KeySecureString.Tooltip = Resources.Activity_DecryptText_Property_KeySecureString_Description;
KeyEncodingString.DisplayName = Resources.Activity_DecryptText_Property_KeyEncodingString_Name;
KeyEncodingString.Tooltip = Resources.Activity_DecryptText_Property_KeyEncodingString_Description;
PlaintextEncodingString.DisplayName = Resources.Activity_DecryptText_Property_PlaintextEncodingString_Name;
PlaintextEncodingString.Tooltip = Resources.Activity_DecryptText_Property_PlaintextEncodingString_Description;
Format.DisplayName = Resources.Activity_DecryptText_Property_Format_Name;
Format.Tooltip = Resources.Activity_DecryptText_Property_Format_Description;
KeyFormat.DisplayName = Resources.Activity_DecryptText_Property_KeyFormat_Name;
KeyFormat.Tooltip = Resources.Activity_DecryptText_Property_KeyFormat_Description;
KdfIterations.DisplayName = Resources.Activity_DecryptText_Property_KdfIterations_Name;
KdfIterations.Tooltip = Resources.Activity_DecryptText_Property_KdfIterations_Description;
AesKeySize.DisplayName = Resources.Activity_DecryptText_Property_AesKeySize_Name;
AesKeySize.Tooltip = Resources.Activity_DecryptText_Property_AesKeySize_Description;
ContinueOnError.DisplayName = Resources.Activity_DecryptText_Property_ContinueOnError_Name;
ContinueOnError.Tooltip = Resources.Activity_DecryptText_Property_ContinueOnError_Description;
PrivateKeyFilePath.DisplayName = Resources.Activity_DecryptText_Property_PrivateKeyFilePath_Name;
PrivateKeyFilePath.Tooltip = Resources.Activity_DecryptText_Property_PrivateKeyFilePath_Description;
Passphrase.DisplayName = Resources.Activity_DecryptText_Property_Passphrase_Name;
Passphrase.Tooltip = Resources.Activity_DecryptText_Property_Passphrase_Description;
PassphraseSecureString.DisplayName = Resources.Activity_DecryptText_Property_PassphraseSecureString_Name;
PassphraseSecureString.Tooltip = Resources.Activity_DecryptText_Property_PassphraseSecureString_Description;
VerifySignature.DisplayName = Resources.Activity_DecryptText_Property_VerifySignature_Name;
VerifySignature.Tooltip = Resources.Activity_DecryptText_Property_VerifySignature_Description;
PublicKeyFilePath.DisplayName = Resources.Activity_DecryptText_Property_PublicKeyFilePath_Name;
PublicKeyFilePath.Tooltip = Resources.Activity_DecryptText_Property_PublicKeyFilePath_Description;
PublicKeyFile.DisplayName = Resources.Activity_DecryptText_Property_PublicKeyFile_Name;
PublicKeyFile.Tooltip = Resources.Activity_DecryptText_Property_PublicKeyFile_Description;
Result.DisplayName = Resources.Activity_DecryptText_Property_Result_Name;
Result.Tooltip = Resources.Activity_DecryptText_Property_Result_Description;
}
}
}
7 changes: 4 additions & 3 deletions ...ptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptCryptoViewModelBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ protected EncryptCryptoViewModelBase(IDesignServices services) : base(services)
protected void ConfigureAlgorithmAndKeyProperties(ref int orderIndex)
{
Algorithm.IsPrincipal = true;
Algorithm.IsRequired = true;
Algorithm.OrderIndex = orderIndex++;
Algorithm.Category = Resources.Input;
Algorithm.DataSource = DataSourceHelper.ForEnum(
Expand All @@ -102,6 +103,8 @@ protected void ConfigureAlgorithmAndKeyProperties(ref int orderIndex)
EncryptionAlgorithm.TripleDES);
Algorithm.Widget = new DefaultWidget { Type = ViewModelWidgetType.Dropdown };

DeprecatedWarning.IsPrincipal = true;
DeprecatedWarning.IsVisible = false;
DeprecatedWarning.OrderIndex = orderIndex++;
DeprecatedWarning.Category = Resources.Input;
DeprecatedWarning.Widget = new TextBlockWidget
Expand All @@ -121,9 +124,8 @@ protected void ConfigureAlgorithmAndKeyProperties(ref int orderIndex)
orderIndex++;

KeyEncodingString.IsPrincipal = false;
KeyEncodingString.IsVisible = true;
KeyEncodingString.OrderIndex = orderIndex++;
KeyEncodingString.Category = Resources.Input;
KeyEncodingString.Category = Resources.Category_Options_Name;

KeyEncodingString.DataSource = _encodingDataSource;
KeyEncodingString.Widget = new DefaultWidget { Type = ViewModelWidgetType.Dropdown, Metadata = new Dictionary<string, string>() };
Expand Down Expand Up @@ -155,7 +157,6 @@ protected void ConfigureEncodingDropdown(DesignInArgument<string> encodingProper
protected void ConfigureInteropProperties(ref int orderIndex)
{
Format.IsPrincipal = false;
Format.IsVisible = true;
Format.OrderIndex = orderIndex++;
Format.Category = Resources.Input;
Format.DataSource = DataSourceHelper.ForEnum(
Expand Down
53 changes: 50 additions & 3 deletions ...es/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptFileViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,11 @@ protected override void InitializeModel()
ConfigureInteropProperties(ref orderIndex);

OutputFilePath.IsPrincipal = false;
OutputFilePath.IsVisible = true;
OutputFilePath.IsRequired = false;
OutputFilePath.OrderIndex = orderIndex++;
OutputFilePath.Category = Resources.Input;
OutputFilePath.Category = Resources.Category_Options_Name;

Overwrite.IsPrincipal = false;
Overwrite.IsPrincipal = true;
Overwrite.OrderIndex = orderIndex++;
Overwrite.Category = Resources.Category_Options_Name;
Overwrite.Widget = new DefaultWidget { Type = ViewModelWidgetType.Toggle };
Expand All @@ -68,6 +67,8 @@ protected override void InitializeModel()
EncryptedFile.IsPrincipal = false;
EncryptedFile.OrderIndex = orderIndex;
EncryptedFile.Category = Resources.Output;

ConfigurePropertyTexts();
}

private void ConfigureInputFileMenuActions()
Expand All @@ -76,6 +77,52 @@ private void ConfigureInputFileMenuActions()
ApplyInputFileVisibility();
}

private void ConfigurePropertyTexts()
{
InputFile.DisplayName = Resources.Activity_EncryptFile_Property_InputFile_Name;
InputFile.Tooltip = Resources.Activity_EncryptFile_Property_InputFile_Description;
InputFilePath.DisplayName = Resources.Activity_EncryptFile_Property_InputFilePath_Name;
InputFilePath.Tooltip = Resources.Activity_EncryptFile_Property_InputFilePath_Description;
Algorithm.DisplayName = Resources.Activity_EncryptFile_Property_Algorithm_Name;
Algorithm.Tooltip = Resources.Activity_EncryptFile_Property_Algorithm_Description;
Key.DisplayName = Resources.Activity_EncryptFile_Property_Key_Name;
Key.Tooltip = Resources.Activity_EncryptFile_Property_Key_Description;
KeySecureString.DisplayName = Resources.Activity_EncryptFile_Property_KeySecureString_Name;
KeySecureString.Tooltip = Resources.Activity_EncryptFile_Property_KeySecureString_Description;
OutputFilePath.DisplayName = Resources.Activity_EncryptFile_Property_OutputFilePath_Name;
OutputFilePath.Tooltip = Resources.Activity_EncryptFile_Property_OutputFilePath_Description;
KeyEncodingString.DisplayName = Resources.Activity_EncryptFile_Property_KeyEncoding_Name;
KeyEncodingString.Tooltip = Resources.Activity_EncryptFile_Property_KeyEncoding_Description;
Format.DisplayName = Resources.Activity_EncryptFile_Property_Format_Name;
Format.Tooltip = Resources.Activity_EncryptFile_Property_Format_Description;
KeyFormat.DisplayName = Resources.Activity_EncryptFile_Property_KeyFormat_Name;
KeyFormat.Tooltip = Resources.Activity_EncryptFile_Property_KeyFormat_Description;
Iv.DisplayName = Resources.Activity_EncryptFile_Property_Iv_Name;
Iv.Tooltip = Resources.Activity_EncryptFile_Property_Iv_Description;
KdfIterations.DisplayName = Resources.Activity_EncryptFile_Property_KdfIterations_Name;
KdfIterations.Tooltip = Resources.Activity_EncryptFile_Property_KdfIterations_Description;
AesKeySize.DisplayName = Resources.Activity_EncryptFile_Property_AesKeySize_Name;
AesKeySize.Tooltip = Resources.Activity_EncryptFile_Property_AesKeySize_Description;
Overwrite.DisplayName = Resources.Activity_EncryptFile_Property_Overwrite_Name;
Overwrite.Tooltip = Resources.Activity_EncryptFile_Property_Overwrite_Description;
ContinueOnError.DisplayName = Resources.Activity_EncryptFile_Property_ContinueOnError_Name;
ContinueOnError.Tooltip = Resources.Activity_EncryptFile_Property_ContinueOnError_Description;
PublicKeyFile.DisplayName = Resources.Activity_EncryptFile_Property_PublicKeyFile_Name;
PublicKeyFile.Tooltip = Resources.Activity_EncryptFile_Property_PublicKeyFile_Description;
PublicKeyFilePath.DisplayName = Resources.Activity_EncryptFile_Property_PublicKeyFilePath_Name;
PublicKeyFilePath.Tooltip = Resources.Activity_EncryptFile_Property_PublicKeyFilePath_Description;
SignData.DisplayName = Resources.Activity_EncryptFile_Property_SignData_Name;
SignData.Tooltip = Resources.Activity_EncryptFile_Property_SignData_Description;
PrivateKeyFilePath.DisplayName = Resources.Activity_EncryptFile_Property_PrivateKeyFilePath_Name;
PrivateKeyFilePath.Tooltip = Resources.Activity_EncryptFile_Property_PrivateKeyFilePath_Description;
Passphrase.DisplayName = Resources.Activity_EncryptFile_Property_Passphrase_Name;
Passphrase.Tooltip = Resources.Activity_EncryptFile_Property_Passphrase_Description;
PassphraseSecureString.DisplayName = Resources.Activity_EncryptFile_Property_PassphraseSecureString_Name;
PassphraseSecureString.Tooltip = Resources.Activity_EncryptFile_Property_PassphraseSecureString_Description;
EncryptedFile.DisplayName = Resources.Activity_EncryptFile_Property_EncryptedFile_Name;
EncryptedFile.Tooltip = Resources.Activity_EncryptFile_Property_EncryptedFile_Description;
}

private void ApplyInputFileVisibility()
{
bool useResource = _inputFileToggle.UseSecondary;
Expand Down
Loading