Skip to content

update documentation for regi-python - #19

Merged
adamkorynta merged 4 commits into
mainfrom
feature/jpype-documentation
Aug 7, 2026
Merged

update documentation for regi-python#19
adamkorynta merged 4 commits into
mainfrom
feature/jpype-documentation

Conversation

@adamkorynta

Copy link
Copy Markdown
Collaborator

add migration and API documentation for regi-python

@adamkorynta
adamkorynta requested a review from rma-psmorris July 16, 2026 20:37
add migration and API documentation for regi-python
Comment thread docs/PYTHON_API.md
Comment thread docs/PYTHON_API.md
@adamkorynta
adamkorynta marked this pull request as ready for review July 24, 2026 19:10
@adamkorynta
adamkorynta requested review from SWF-WM and krowvin July 24, 2026 22:18

@rma-psmorris rma-psmorris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit of feedback

Comment thread docs/JYTHON_TO_JPYPE_MIGRATION.md Outdated
Comment thread docs/PYTHON_API.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread AGENTS.md

@rma-psmorris rma-psmorris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Comment thread AGENTS.md
- python to java bridge code
- prefer modern Python style and small, testable helpers
- `district-scripts/`
- active district-owned operational scripts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to clarify if the district scripts here will be bundled in the wheel, or if districts will have their scripts in their Batch repos.

i.e.
usace-watermanagement/swt-wm-cwbi-jobs

The word active could mean these are the primary scripts. James and I were discussing if the scripts are in the above -wm- repo if there would be a desync issue. But probably not a problem since they rarely update and this repo is just doing a best check against previously known scripts?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we could bundle the scripts, I think it would defeat the purpose to require rebundling this library for script updates. The intent is that the actual production scripts be in repos like usace-watermanagement/swt-wm-cwbi-jobs.

I wanted to convey specifically to agents reading the AGENTS.md that the scripts included here represent the "active" production scripts. At least in my testing with Claude/Codex/Junie that has been sufficient to keep the agents from trying to change these files during library updates and to keep the library user's public API functionality intact (without explicit directory to make a breaking change).

@SWF-WM SWF-WM left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on my end

@krowvin krowvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had one other comment, not a blocker

@adamkorynta
adamkorynta merged commit f72bbac into main Aug 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants