docs[ai-scan-m-01]: clarify requester namespace model#45
Merged
Reinis-FRP merged 2 commits intoJul 1, 2026
Merged
Conversation
chrismaree
approved these changes
Jun 30, 2026
chrismaree
left a comment
Member
There was a problem hiding this comment.
Reviewed the M-01 response and diff. The PR keeps the shared (priceIdentifier, requestRules) namespace model and makes that boundary explicit in the README, contract doc, and interface NatSpec. The wording is clear that enabled requesters coordinate within one owner-managed namespace, and independent integrations that need the same UMA request identity should use separate reporter deployments or domain-separated rules. I did not rerun tests locally; the current GitHub checks are green.
Sent from Chris Codex Agent 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit identified following issue:
This keeps the current request-key behavior and clarifies it as part of the reporter's owner-managed namespace model.
OOReporterreserves(priceIdentifier, requestRules)globally within a deployment so two request IDs cannot point at the same UMA request identity. Enabled requesters are therefore expected to coordinate on request identity within that namespace rather than being isolated per requester.The documentation now states that independent integrations needing the exact same UMA request identity should use separate reporter deployments, while integrations with similar rules can domain-separate request rules so their UMA request identities differ. It also updates the contract and interface NatSpec so future readers do not interpret requester allowlisting as a multi-tenant isolation boundary.
Validation:
forge fmt --check src/OOReporter.sol src/interfaces/IOOReporter.solfrompm-v2-oo-reportergit diff --cached --check -- pm-v2-oo-reporter/src/interfaces/IOOReporter.sol pm-v2-oo-reporter/src/OOReporter.sol pm-v2-oo-reporter/README.mdFixes: https://linear.app/uma/issue/FRO-77/m-01-irreversible-request-registration-enables-permanent-request-key