Skip to content

fix(ui5-date-picker): fix flaky tests #13818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GDamyanov wants to merge 12 commits into
base: main
Choose a base branch
from
+11 −9
Open

fix(ui5-date-picker): fix flaky tests #13818

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a53fc9d
fix: stabalize DatePicker tests
GDamyanov Jul 13, 2026
4ba206a
fix: stabilize tests
GDamyanov Jul 13, 2026
4c87a8a
fix: clear cache when language is changed
GDamyanov Jul 13, 2026
c8b0e09
test: refactor tests
GDamyanov Jul 13, 2026
4c6ec45
fix: stabilize tests
GDamyanov Jul 14, 2026
ed276bc
test: isolate tests
GDamyanov Jul 14, 2026
721c224
test: await setLanguage promise
GDamyanov Jul 14, 2026
c4ee43a
test: move locale test into seperate module
GDamyanov Jul 14, 2026
36eb12c
test
GDamyanov Jul 14, 2026
77c1aa2
test
GDamyanov Jul 14, 2026
6b4fec1
Merge branch 'main' into unstable-dp-tests
GDamyanov Jul 17, 2026
99af681
Merge branch 'main' into unstable-dp-tests
GDamyanov Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/main/cypress/specs/DatePicker.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ import DatePicker from "../../src/DatePicker.js";
import Label from "../../src/Label.js";
import { DATEPICKER_POPOVER_ACCESSIBLE_NAME } from "../../src/generated/i18n/i18n-defaults.js";

describe.skip("Date Picker Tests", () => {
describe("Date Picker Tests", () => {
afterEach(() => {
cy.wrap({ setLanguage }).then(api => api.setLanguage("en"));
});

it("input renders", () => {
cy.mount(<DatePicker></DatePicker>);

Expand Down Expand Up @@ -34,7 +38,9 @@ describe.skip("Date Picker Tests", () => {

it("input receives value in format pattern depending on the set language", () => {
cy.wrap({ setLanguage })
.then(api => api.setLanguage("bg"));
.then(api => {
return api.setLanguage("bg");
});

cy.mount(<DatePicker value="11 декември 2018г." formatPattern="long"></DatePicker>);

Expand All @@ -56,9 +62,6 @@ describe.skip("Date Picker Tests", () => {
cy.get<DatePicker>("@datePicker")
.ui5DatePickerGetPopoverDate(timestamp_11_Dec_2018)
.should("have.class", "ui5-dp-item--selected");

cy.wrap({ setLanguage })
.then(api => api.setLanguage("en"));
});

it("custom formatting", () => {
Expand Down Expand Up @@ -318,7 +321,9 @@ describe.skip("Date Picker Tests", () => {

it("respect first day of the week - monday", () => {
cy.wrap({ setLanguage })
.then(api => api.setLanguage("bg"));
.then(api => {
return api.setLanguage("bg");
});

cy.mount(<DatePicker value="фев 6, 2019" formatPattern="MMM d, y"></DatePicker>);

Expand All @@ -336,9 +341,6 @@ describe.skip("Date Picker Tests", () => {
cy.get<DatePicker>("@datePicker")
.ui5DatePickerGetPopoverDate(timestamp_3_Feb_2019)
.should("have.class", "ui5-dp-wday6");

cy.wrap({ setLanguage })
.then(api => api.setLanguage("en"));
});

it("if today is 30 jan, clicking next month does not skip feb", () => {
Expand Down
Loading