fix(ui5-shellbar): preserve insertion order for ShellBarItems#13590
Open
NakataCode wants to merge 1 commit into
Open
fix(ui5-shellbar): preserve insertion order for ShellBarItems#13590NakataCode wants to merge 1 commit into
NakataCode wants to merge 1 commit into
Conversation
Collaborator
|
🚀 Deployed on https://pr-13590--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShellBarItems with icon="feedback" or icon="sys-help" were always displayed at the end of the actions area, ignoring their position in the DOM. Items now appear in the same order they are declared.
Remove PREDEFINED_PLACE_ITEMS, sortItems(), and all call sites, passing this.items directly instead.
JIRA: BGSOFUIPIRIN-7070