refactor(project): Reset result cache state on source-changed retry#1402
Merged
Conversation
allTasksCompleted reset the index state when throwing SourceChangedDuringBuildError but left resultCacheState untouched. Because BuildServer reuses the same ProjectBuildCache instance across retries, a prior prepareProjectBuildAndValidateCache that had transitioned the field to NO_CACHE or FRESH_AND_IN_USE caused the retry to trip the PENDING_VALIDATION invariant in the RESTORING_DEPENDENCY_INDICES branch and fail with "Unexpected result cache state after restoring dependency indices for project XYZ: no_cache".
RandomByte
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allTasksCompleted reset the index state when throwing SourceChangedDuringBuildError but left resultCacheState untouched. Because BuildServer reuses the same ProjectBuildCache instance across retries, a prior prepareProjectBuildAndValidateCache that had transitioned the field to NO_CACHE or FRESH_AND_IN_USE caused the retry to trip the PENDING_VALIDATION invariant in the
RESTORING_DEPENDENCY_INDICES branch and fail with
"Unexpected result cache state after restoring dependency indices for project XYZ: no_cache".