refactor(fs): Use structuredClone for Resource statInfo deep copy#1401
Merged
Conversation
The `clone` package recreates internal-slot-backed values like Date and Temporal.Instant as prototype-only copies, stripping the slot. On Node 26 fs.Stats exposes Temporal.Instant getters whose toJSON performs a strict internal-slot check and throws, breaking any consumer that JSON-stringifies a cloned stat (e.g. @ui5/builder's theme worker IPC). Replace `clone` with a small helper that preserves the prototype, copies function-valued own properties by reference, and runs each data value through structuredClone — which correctly handles Date, Temporal, Map, Set, typed arrays, etc. sourceMetadata uses structuredClone directly. The unmaintained `clone` dependency is removed from @ui5/fs. This is an up-port of SAP/ui5-fs#697 hence the commit message is not using the "fix" prefix.
matz3
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up-port of SAP/ui5-fs#697
The
clonepackage recreates internal-slot-backed values like Date andTemporal.Instant as prototype-only copies, stripping the slot. On Node 26
fs.Stats exposes Temporal.Instant getters whose toJSON performs a strict
internal-slot check and throws, breaking any consumer that JSON-stringifies
a cloned stat (e.g. @ui5/builder's theme worker IPC).
Replace
clonewith a small helper that preserves the prototype, copiesfunction-valued own properties by reference, and runs each data value through
structuredClone — which correctly handles Date, Temporal, Map, Set, typed
arrays, etc. sourceMetadata uses structuredClone directly. The unmaintained
clonedependency is removed from @ui5/fs.This is an up-port of SAP/ui5-fs#697 hence the
commit message is not using the "fix" prefix.