refactor(project): Replace chokidar with @parcel/watcher#1400
Open
matz3 wants to merge 1 commit into
Open
Conversation
matz3
force-pushed
the
replace-chokidar-with-parcel-watcher
branch
from
19dcaf2 to
4d94da3
Compare
matz3
changed the title
Watching a large number of files with chokidar is not efficient, especially on Windows and slow file systems. Parcel's watcher is more efficient as it uses a native C++ Node module. Changing WatchHandler log level to "silly" to avoid duplicate log entries as BuildServer already logs the events at "verbose" level.
matz3
force-pushed
the
replace-chokidar-with-parcel-watcher
branch
from
4d94da3 to
dc94c88
Compare
Member
Author
|
This PR will most likely also solve sporadic test failures in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watching a large number of files with chokidar is not efficient, especially on Windows and slow file systems.
Parcel's watcher is more efficient as it uses a native C++ Node module.
Changing WatchHandler log level to "silly" to avoid duplicate log entries as BuildServer already logs the events at "verbose" level.