ci: Add engine compatibility check for PRs (external package)#1360
Open
ci: Add engine compatibility check for PRs (external package)#1360
Conversation
github-actions
bot
added
blocked
d3xter666
force-pushed
the
engine-compatibility-checks-script
branch
from
6733230 to
59527d0
Compare
d3xter666
force-pushed
the
engine-compatibility-checks-script
branch
from
d322d6c to
b304509
Compare
d3xter666
changed the title
d3xter666
changed the title
Contributor
✅ Engine CompatibilityProject engines.node: All dependencies are compatible with the project's engine range. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial idea: #1356
JIRA: CPOUI5FOUNDATION-1225
Why not just use check-engine-light directly?
We could simplify this workflow by running
check-engine-lightas a regular CI step — if all dependencies are compatible it exits silently, and if any are incompatible it exits with code 1, failing the build. This would behave almost identically tonpm ci --engine-strict.However, that approach is binary: the PR either passes or fails, with no visibility into which packages are incompatible or what their engine ranges are.
This extended setup runs
check-engine-lightand parses its output into a PR comment table showing each incompatible package and its declared Node range. The check is intentionally non-blocking — it reports incompatibilities without preventing the PR from being merged.