feat(cli): pin GitHub Action version default to the released version#713
Merged
Conversation
The action's 'version' input defaulted to 'latest', which read as a rolling tag even though install.sh already ships a baked, release-bumped version. Default it to the concrete version instead, bumped by the release process, so pinning the action by SHA pins a visible version at the call site. Pass 'version: latest' to keep the build-time tag.
JesusValeraDev
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The action's
versioninput defaulted tolatest, which reads like a rolling tag even thoughinstall.shalready ships a baked, release-bumpedLATEST_BASHUNIT_VERSIONand never makes a runtime "newest release" lookup. So pinning the action by SHA already pinned the version — the default just hid that.This makes the default a concrete version string in
action.yml, bumped by the release process, so the pinned version is visible right at the call site. Pinning the action by SHA pins a visible bashunit version with no ambiguity.Changes
action.yml:versiondefaultlatest→'0.38.0'; clearer descriptionrelease.sh: newrelease::update_action_version, addedaction.ymltoRELEASE_FILES, wired into both the sandbox and real release steps (with state recording)mock_action.ymlfixture: bumps only the numeric default, leaveslib/'true'untouchedCHANGELOG.mdentryNotes
No behavior change for callers passing
version: latestexplicitly — that still installs the build-time pinned tag. Context: phpstan-src#5826 review.Checks
make sa,make lintpass./bashunit tests/and./bashunit --parallel tests/green