chore: remove semver from dependencies field#1700
Conversation
|
Thanks. This may be a possible optimisation. We've used semver forever, I'm not sure how much I want to remove it. Maybe though |
|
@copilot please review this PR. Examine any possible issues that there might be |
I only move semver to devDependencies. Using We can use semiver if we need to compare pre-release version, because my code isn't doing that. But I think we can do this. |
|
We definitely can do this, at least for now though I think I'm happy to leave things as they are. Thanks though. |
|
It is interesting to think about this though https://github.com/TypeStrong/ts-loader/tasks/45425eb4-463b-4a8e-90e3-3784eb11735b?author=johnnyreilly&q=is%3Aopen |
|
hmmm now I'm wondering more - I'm getting copilot to experiment: #1701 |
|
Interestingly, ts-loader supports TypeScript 3.6.3+. The semver is used to test whether the compiler version is 3.6.3+. Given that's the minimum supported version, it's arguable whether the test is even necessary. I'm not sure it is |
|
I'm still not sure if I'll make changes to ts-loader or not - but I am enjoying pondering it! |
We only use
.gtemethod fromsemverpackage on end-user code. Which can be written like this.