Skip to content

chore: remove semver from dependencies field#1700

Open
hyperz111 wants to merge 3 commits into
TypeStrong:mainfrom
hyperz111:drop-semver
Open

chore: remove semver from dependencies field#1700
hyperz111 wants to merge 3 commits into
TypeStrong:mainfrom
hyperz111:drop-semver

Conversation

@hyperz111

Copy link
Copy Markdown

We only use .gte method from semver package on end-user code. Which can be written like this.

score = current - expected
if (score >= 0):
  return true;

@johnnyreilly

Copy link
Copy Markdown
Member

Thanks. This may be a possible optimisation. We've used semver forever, I'm not sure how much I want to remove it. Maybe though

@johnnyreilly

Copy link
Copy Markdown
Member

@copilot please review this PR. Examine any possible issues that there might be

@hyperz111

Copy link
Copy Markdown
Author

Thanks. This may be a possible optimisation. We've used semver forever, I'm not sure how much I want to remove it. Maybe though

I only move semver to devDependencies. Using semver.gte method means we have to do a full version parse and it's a bit slower.

We can use semiver if we need to compare pre-release version, because my code isn't doing that.

But I think we can do this.

@johnnyreilly

Copy link
Copy Markdown
Member

We definitely can do this, at least for now though I think I'm happy to leave things as they are. Thanks though.

@johnnyreilly

Copy link
Copy Markdown
Member

@johnnyreilly

johnnyreilly commented Jun 19, 2026

Copy link
Copy Markdown
Member

hmmm now I'm wondering more - I'm getting copilot to experiment: #1701

@johnnyreilly

Copy link
Copy Markdown
Member

Interestingly, ts-loader supports TypeScript 3.6.3+. The semver is used to test whether the compiler version is 3.6.3+. Given that's the minimum supported version, it's arguable whether the test is even necessary. I'm not sure it is

@johnnyreilly

Copy link
Copy Markdown
Member

I'm still not sure if I'll make changes to ts-loader or not - but I am enjoying pondering it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants