Fix type of http.response.status_code attribute#287
Open
NthPortal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracingwidensu16tou64when using it as an attribute (see here), buttracing-opentelemetrydoes not (and cannot) handleu64(see here), so it defaults to being recorded as a string. explicitly converting fromu16toi64allows the attribute to be recorded properly bytracing-opentelemetry.I have tested this change locally, and it correctly records the value in
opentelemetryspans as ani64. I did not see any current tests where I could easily add a couple lines to assert this change, and I'm not sure how you'd want to test something like that.relatedly,
server.portis also incorrectly recorded as a string, but I have been unable to determine why, given that it is explicitly converted toi64