Use std::conditional and add engine guards (for compatibility with UE 5.8) - #300
Open
joanpark wants to merge 1 commit into
Open
Use std::conditional and add engine guards (for compatibility with UE 5.8)#300joanpark wants to merge 1 commit into
joanpark wants to merge 1 commit into
Conversation
Replace TChooseClass usage with std::conditional_t in RealtimeMeshBuilder to remove dependency on Templates/ChooseClass and improve compatibility. Remove the now-unneeded include. Add #if !RMC_ENGINE_ABOVE_5_7 guards around bIsSplineProxy and ImposterIndex initializations in RealtimeMeshSectionProxy.cpp and RealtimeMeshNaniteResourcesInterface.h to avoid referencing members not present in newer engine versions. Files changed: RealtimeMeshBuilder.h, RealtimeMeshSectionProxy.cpp, RealtimeMeshNaniteResourcesInterface.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace TChooseClass usage with std::conditional_t in RealtimeMeshBuilder to remove dependency on Templates/ChooseClass and improve compatibility.
Remove the now-unneeded include.
Add #if !RMC_ENGINE_ABOVE_5_7 guards around bIsSplineProxy and ImposterIndex initializations in RealtimeMeshSectionProxy.cpp and RealtimeMeshNaniteResourcesInterface.h to avoid referencing members not present in newer engine versions.
Files changed: RealtimeMeshBuilder.h, RealtimeMeshSectionProxy.cpp, RealtimeMeshNaniteResourcesInterface.h.