specification: updating for latest linux changes#35
Open
dpsmith wants to merge 1 commit intoTrenchBoot:masterfrom
Open
specification: updating for latest linux changes#35dpsmith wants to merge 1 commit intoTrenchBoot:masterfrom
dpsmith wants to merge 1 commit intoTrenchBoot:masterfrom
Conversation
Update the specification to align with the changes made for the Linux maintainers. Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
| u64 boot_params_addr; | ||
| u64 slrt; | ||
| u64 txt_info; | ||
| u64 txt_info; |
Comment on lines
+200
to
+203
| :uuid0: Chunk 0 of UUID, 9082AC5A | ||
| :uuid1: Chunk 1 of UUID, 74A7476F | ||
| :uuid2: Chunk 2 of UUID, A2555C0F | ||
| :uuid3: Chunk 3 of UUID, 42B651CB |
Member
There was a problem hiding this comment.
Should it be unconditionally included in non-TXT binaries as well? It probably makes sense for x86 as vendor can be easily detected, but I'm not so sure about other architectures.
| :uuid1: Chunk 1 of UUID, 74A7476F | ||
| :uuid2: Chunk 2 of UUID, A2555C0F | ||
| :uuid3: Chunk 3 of UUID, 42B651CB | ||
| :header_len: Length of the header. |
Member
There was a problem hiding this comment.
To be unambiguous since this is not always the case:
Suggested change
| :header_len: Length of the header. | |
| :header_len: Length of the header in bytes. |
| :header_len: Length of the header. | ||
| :version: Header version. | ||
| :entry_point: Address of the DLME entry point. | ||
| :first_valid_page: Address to first valid page of DLME. |
Member
There was a problem hiding this comment.
Suggested change
| :first_valid_page: Address to first valid page of DLME. | |
| :first_valid_page: Address of the first valid 4KiB-page of DLME. |
I suppose it also needs to have zeroes in its lowest bits.
Comment on lines
+208
to
+209
| :start: Offset to first byte of DLME within page space. | ||
| :end: Offset to last byte + 1 of DLME within page space. |
Member
There was a problem hiding this comment.
The base for the offsets is unspecified.
| Handler to facilitate it in launching the kernel. | ||
|
|
||
|
|
||
| DLME Header Structure |
Member
There was a problem hiding this comment.
Are there any alignment requirements?
| | **1.3** - All other registers besides EDI/RDI are not guarenteed | ||
| | **1.4** - The invoking code **SHALL** use a long jump to the DLE Handler | ||
| | **1.5** - The DLE Handler **SHALL NOT** return control on error | ||
| | **2.3** - All other registers besides EDI/RDI are not guarenteed |
Member
There was a problem hiding this comment.
A typo:
Suggested change
| | **2.3** - All other registers besides EDI/RDI are not guarenteed | |
| | **2.3** - All other registers besides EDI/RDI are not guaranteed |
| typedef struct tdEFI_SLAUNCH_PROTOCOL { | ||
| EFI_SLAUNCH_SLRT_UPDATE_REGISTER_DLME RegisterDlme; | ||
| EFI_SLAUNCH_LAUNCH Launch; | ||
| } EFI_SLAUNCH_PROTOCOL |
Member
There was a problem hiding this comment.
Suggested change
| } EFI_SLAUNCH_PROTOCOL | |
| } EFI_SLAUNCH_PROTOCOL; |
Comment on lines
+282
to
+283
| IN EFI_PHYSICAL_ADDRESS *DlmeBase | ||
| IN EFI_PHYSICAL_ADDRESS *DlmeHeader |
Member
There was a problem hiding this comment.
Suggested change
| IN EFI_PHYSICAL_ADDRESS *DlmeBase | |
| IN EFI_PHYSICAL_ADDRESS *DlmeHeader | |
| IN EFI_PHYSICAL_ADDRESS *DlmeBase, | |
| IN EFI_PHYSICAL_ADDRESS *DlmeHeader, |
Comment on lines
+454
to
+455
| :dlme_header_offset: The offest into the DLME of the DLME Header. | ||
| :dlme_config_table: The offsee into the DLME of the DLME Config Table. |
Member
There was a problem hiding this comment.
Suggested change
| :dlme_header_offset: The offest into the DLME of the DLME Header. | |
| :dlme_config_table: The offsee into the DLME of the DLME Config Table. | |
| :dlme_header_offset: The offset into the DLME of the DLME Header. | |
| :dlme_config_table: The offset into the DLME of the DLME Config Table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the specification to align with the changes made for the Linux maintainers.