Fix spelling errors in part3_fares documentation and comments#1039
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the NeTEx Part 3 (fares) XSD documentation quality by correcting spelling/wording mistakes in <xsd:documentation> and XML comments, without changing any schema components (types, elements, enums), preserving validation/backward compatibility.
Changes:
- Corrects repeated “ENTIITY” section-divider comment typos to “ENTITY” across multiple fares XSDs.
- Fixes several documentation typos/phrasing issues (e.g., “assoictaed” → “associated”, “atre” → “are”, “ine” → “one”, etc.).
- Improves clarity of a few documentation sentences (e.g., SALE DISCOUNT RIGHT wording, Optimised context wording).
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xsd/netex_part_3/part3_fares/netex_validableElement_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_usageParameterTravel_version.xsd | Fixes documentation typo (“atre” → “are”). |
| xsd/netex_part_3/part3_fares/netex_usageParameterTravel_support.xsd | Fixes documentation typo (“specifed” → “specified”). |
| xsd/netex_part_3/part3_fares/netex_usageParameterEligibility_version.xsd | Fixes documentation typos (“changiing/numbe” → “changing/number”). |
| xsd/netex_part_3/part3_fares/netex_usageParameterAfterSales_support.xsd | Fixes documentation typo (“specifed” → “specified”). |
| xsd/netex_part_3/part3_fares/netex_usageParameter_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_typeOfTravelDocument_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_timeStructureFactor_version.xsd | Fixes “ENTIITY” typo and documentation text (“assoictaed…”). |
| xsd/netex_part_3/part3_fares/netex_salesOfferPackage_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_salesDistribution_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_qualityStructureFactor_version.xsd | Fixes “ENTIITY” typo and documentation text (“EDMAND” → “DEMAND”). |
| xsd/netex_part_3/part3_fares/netex_geographicStructureFactor_version.xsd | Fixes “ENTIITY” typo and documentation text (“assoictaed…”). |
| xsd/netex_part_3/part3_fares/netex_fareTable_version.xsd | Fixes duplicated section divider typos (“ENTIITY” → “ENTITY”). |
| xsd/netex_part_3/part3_fares/netex_fareStructureElement_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_fareStructure_version.xsd | Fixes documentation text (“assoictaed…” → “associated…”). |
| xsd/netex_part_3/part3_fares/netex_fareSeries_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_fareProduct_version.xsd | Fixes “ENTIITY” typo and documentation wording (“SALE DISCOUNT RIGHT…”, “ine” → “one”). |
| xsd/netex_part_3/part3_fares/netex_farePrice_version.xsd | Fixes documentation typos (“beteen”, “the the” duplication). |
| xsd/netex_part_3/part3_fares/netex_distanceMatrixElement_version.xsd | Fixes “ENTIITY” typo in section divider comment. |
| xsd/netex_part_3/part3_fares/netex_calculationParameters_version.xsd | Fixes “ENTIITY” typo and documentation wording (“whcih…”, “comtainign…”, etc.). |
| xsd/netex_part_3/part3_fares/netex_accessRightParameter_version.xsd | Fixes “ENTIITY” typo and documentation typos (“chargable”, “fo” → “of”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
skinkie
approved these changes
Jul 9, 2026
skinkie
left a comment
Contributor
There was a problem hiding this comment.
I guess we all know who wrote them.
tim-rivett
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear NeTExians,
While working on the NAPCORE Helpdesk app, which uses the NeTex documentation as the source of truth, I found spelling mistakes that can be easily corrected without breaking anything.
Therefore, this PR fixes spelling errors in the
xsd/netex_part_3/part3_faresschemas. All changes are confined to<xsd:documentation>text and XML comments — no schema components (elements, types, enumeration values) are modified, so there is no impact on validation or backward compatibility.Changes
ENTIITY→ENTITYin section-divider comments (17 occurrences across the fares files)netex_fareStructure_version.xsd,netex_geographicStructureFactor_version.xsd,netex_timeStructureFactor_version.xsd)netex_usageParameterTravel_version.xsd)netex_fareProduct_version.xsd)netex_fareProduct_version.xsd)netex_calculationParameters_version.xsd)netex_accessRightParameter_version.xsd)netex_accessRightParameter_version.xsd)netex_usageParameterAfterSales_support.xsd,netex_usageParameterTravel_support.xsd)netex_qualityStructureFactor_version.xsd)netex_farePrice_version.xsd)netex_usageParameterEligibility_version.xsd)Deliberately left out (breaking change!)
Exchangable*misspelling (e.g.ExchangableToEnumeration,ExchangableTo,IsExchangable,ExchangableFrom*/ExchangableUntil*and the matching enumeration values innetex_entity_support.xsd) is not fixed here: those are schema component names used in instance documents, so renaming them is a breaking change that needs a separate decision (e.g. deprecated aliases at the next version).Verification
NeTEx_publication.xsdcompiles andexamples/functions/fares/Netex_51.1_Bus_SimpleFares_PointToPoint_SingleProduct.xmlvalidates against it (xmllint).