docs(wire-formats): correct XML codec fall-through description - #232
Draft
ottobolyos wants to merge 2 commits into
Draft
docs(wire-formats): correct XML codec fall-through description#232ottobolyos wants to merge 2 commits into
ottobolyos wants to merge 2 commits into
Conversation
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 19, 2026
…econcile-cascade 20260819T134500Z)
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 19, 2026
…through description
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 19, 2026
…through description
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 19, 2026
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 19, 2026
ottobolyos
force-pushed
the
docs/wire-formats-xml-fallthrough-to-max
branch
from
August 19, 2026 22:06
6f49f26 to
38e8f20
Compare
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 19, 2026
ottobolyos
force-pushed
the
docs/wire-formats-xml-fallthrough-to-max
branch
2 times, most recently
from
August 21, 2026 08:34
d37af18 to
3e5cc3c
Compare
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 21, 2026
…ion and v1.9 caveat sibling sites
ottobolyos
force-pushed
the
docs/wire-formats-xml-fallthrough-to-max
branch
from
August 21, 2026 16:06
3e5cc3c to
83cb1d1
Compare
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 21, 2026
…integration/up-to-pr-232
ottobolyos
added a commit
to ottobolyos/mtconnect.net
that referenced
this pull request
Aug 21, 2026
…integration/up-to-pr-232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the stale claim that v2.6/v2.7 XML namespaces fall through to the v2.5 reader path with a description matching the current dispatch behavior.
Root cause
docs/wire-formats/xml.mddescribed the codec's fallback for unrecognized namespaces as reading against the v2.5 path. That was accurate against the old dispatch chain, which defaulted tonew Version()on an unmatched namespace. It no longer matches the code.Fix
Before:
After:
Dime review cycle 1
Retroactive backfill (2026-08-20). The initial 6-agent Ultrareview cycle exercised the docs-only fall-through fix inline against #229's code fix. Ledger reconstruction from commit history:
[DOCS]documentation-audit — line 86 fall-through description patched to match theMTConnectVersions.Maxfallback landed by fix(xml): dispatch v2.6/v2.7 namespaces + default unknown to Max #229; closed atomically indocs(wire-formats): correct XML codec fall-through description(38b99ac).[FINDING]code-review — verified against fix(xml): dispatch v2.6/v2.7 namespaces + default unknown to Max #229's code fix: fallback returnsMTConnectVersions.Max(currently v2.7) for unrecognized namespaces, matching the new docs description.[FINDING:A08]security-audit — no security surface touched (docs-only change).[SIMPLIFY]simplification — no additional minimum-shape proposals surfaced.[IMPROVE]improvement — no impact-ranked follow-ups surfaced.[TEST]test-coverage-audit — no test surface touched (docs-only change); the dispatch-chain behavior is pin-tested by fix(xml): dispatch v2.6/v2.7 namespaces + default unknown to Max #229's[TEST]findings.Dime review cycle 2
Retroactive backfill (2026-08-20). Second cycle re-opened after #229's Ultrareview surfaced F-DOC-002 + F-DOC-003 tracking three additional stale sites in the same file. Ledger:
[DOCS]documentation-audit F-DOC-002/F-DOC-003 — three sibling stale sites surfaced by fix(xml): dispatch v2.6/v2.7 namespaces + default unknown to Max #229's cycle 1 review; extended patch atomically (bug-class-atomic rule) indocs(wire-formats): extend fall-through fix to cover v2.7 Max annotation...(38e8f20):(Zero unfixed findings — Ready-eligible.)
Depends on