Skip to content

docs(wire-formats): correct XML codec fall-through description - #232

Draft
ottobolyos wants to merge 2 commits into
TrakHound:masterfrom
ottobolyos:docs/wire-formats-xml-fallthrough-to-max
Draft

docs(wire-formats): correct XML codec fall-through description#232
ottobolyos wants to merge 2 commits into
TrakHound:masterfrom
ottobolyos:docs/wire-formats-xml-fallthrough-to-max

Conversation

@ottobolyos

@ottobolyos ottobolyos commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Replace the stale claim that v2.6/v2.7 XML namespaces fall through to the v2.5 reader path with a description matching the current dispatch behavior.

Root cause

docs/wire-formats/xml.md described the codec's fallback for unrecognized namespaces as reading against the v2.5 path. That was accurate against the old dispatch chain, which defaulted to new Version() on an unmatched namespace. It no longer matches the code.

Fix

Before:

For v2.6 and v2.7 namespaces, the codec falls through to the v2.5 reader path; the library's compliance posture for those versions is tracked under Compliance.

After:

For any namespace not enumerated above — including future spec versions the library has not yet been rebuilt against — the codec defaults to the latest supported version (MTConnectVersions.Max) rather than to an older reader path. This preserves forward compatibility: an incoming document declaring a namespace one minor version ahead of the library's compiled surface is still read against the newest known reader. The library's compliance posture for v2.6 and v2.7 is tracked under Compliance.

Dime review cycle 1

Retroactive backfill (2026-08-20). The initial 6-agent Ultrareview cycle exercised the docs-only fall-through fix inline against #229's code fix. Ledger reconstruction from commit history:

Dime review cycle 2

Retroactive backfill (2026-08-20). Second cycle re-opened after #229's Ultrareview surfaced F-DOC-002 + F-DOC-003 tracking three additional stale sites in the same file. Ledger:

  • [DOCS] documentation-audit F-DOC-002/F-DOC-003 — three sibling stale sites surfaced by fix(xml): dispatch v2.6/v2.7 namespaces + default unknown to Max #229's cycle 1 review; extended patch atomically (bug-class-atomic rule) in docs(wire-formats): extend fall-through fix to cover v2.7 Max annotation... (38e8f20):
    • Line 3: "v1.0 through v2.5" → "v1.0 through v2.7"
    • Line 82: added v2.6 + v2.7 rows to the XSD-per-version table + moved Max annotation from v2.5 row to v2.7 row
    • Line 119: v1.9 caveat "returns the default empty Version" → "falls through to MTConnectVersions.Max (currently v2.7)"

(Zero unfixed findings — Ready-eligible.)

Depends on

ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 19, 2026
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 19, 2026
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 19, 2026
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 19, 2026
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 19, 2026
@ottobolyos
ottobolyos force-pushed the docs/wire-formats-xml-fallthrough-to-max branch from 6f49f26 to 38e8f20 Compare August 19, 2026 22:06
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 19, 2026
@ottobolyos
ottobolyos force-pushed the docs/wire-formats-xml-fallthrough-to-max branch 2 times, most recently from d37af18 to 3e5cc3c Compare August 21, 2026 08:34
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 21, 2026
@ottobolyos
ottobolyos force-pushed the docs/wire-formats-xml-fallthrough-to-max branch from 3e5cc3c to 83cb1d1 Compare August 21, 2026 16:06
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 21, 2026
ottobolyos added a commit to ottobolyos/mtconnect.net that referenced this pull request Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant