fix(xml): dispatch v2.6/v2.7 namespaces + default unknown to Max

libraries/MTConnect.NET-XML/MTConnect.NET-XML.csproj

@@ -72,6 +72,11 @@
 		<ProjectReference Include="..\MTConnect.NET-Common\MTConnect.NET-Common.csproj" />
 	</ItemGroup>
 
+	<ItemGroup>
+		<!-- Grants MTConnect.NET-XML-Tests reach into the internal helpers (MTConnectVersion, Namespaces) that have no public equivalent. The assembly is not strong-named, so no PublicKey clause is required. -->
+		<InternalsVisibleTo Include="MTConnect.NET-XML-Tests" />
+	</ItemGroup>
+
 	<ItemGroup>
 		<None Include="README-Nuget.md">
 			<Pack>True</Pack>

libraries/MTConnect.NET-XML/MTConnectVersion.cs

@@ -8,7 +8,7 @@ namespace MTConnect
     internal static class MTConnectVersion
     {
         /// <summary>
-        /// Gets the Version of the MTConnect standard being used based on the XML Namespace that is used
+        /// Gets the Version of the MTConnect standard from a raw XML document by extracting the root element's namespace URI and dispatching through <see cref="GetByNamespace"/>.
         /// </summary>
         public static Version Get(string xml)
         {
@@ -17,12 +17,14 @@ public static Version Get(string xml)
         }
 
         /// <summary>
-        /// Gets the Version of the MTConnect standard being used based on the XML Namespace that is used
+        /// Gets the Version of the MTConnect standard from an already-resolved namespace URI. Returns <see cref="MTConnectVersions.Max"/> when the namespace is null, empty, or does not match a declared MTConnect namespace.
         /// </summary>
         public static Version GetByNamespace(string ns)
         {
             if (ns != null)
             {
+                if (Namespaces.Version27.Match(ns)) return MTConnectVersions.Version27;
+                if (Namespaces.Version26.Match(ns)) return MTConnectVersions.Version26;
                 if (Namespaces.Version25.Match(ns)) return MTConnectVersions.Version25;
                 if (Namespaces.Version24.Match(ns)) return MTConnectVersions.Version24;
                 if (Namespaces.Version23.Match(ns)) return MTConnectVersions.Version23;
@@ -40,7 +42,8 @@ public static Version GetByNamespace(string ns)
                 if (Namespaces.Version10.Match(ns)) return MTConnectVersions.Version10;
             }
 
-            return new Version();
+            // unknown namespace → default to latest supported version
+            return MTConnectVersions.Max;
         }
     }
-}
+}

libraries/MTConnect.NET-XML/Namespaces.cs

@@ -21,12 +21,34 @@ internal static class Namespaces
 
         public static string Get(string xml)
         {
-            var doc = new XmlDocument();
-            doc.LoadXml(xml);
-            if (doc != null && doc.DocumentElement != null)
+            if (string.IsNullOrEmpty(xml)) return null;
+
+            // XmlDocument.LoadXml delegates to an internal XmlReader whose
+            // DtdProcessing default varies across TFMs and whose XmlResolver
+            // historically resolved external entities. Route the parse through
+            // an explicit XmlReader with DTD processing prohibited and no
+            // resolver so unknown or hostile documents cannot exercise
+            // external-entity or entity-expansion (billion-laughs) paths.
+            var settings = new XmlReaderSettings
             {
-                return doc.DocumentElement.NamespaceURI;
+                DtdProcessing = DtdProcessing.Prohibit,
+                XmlResolver = null,
+            };
+
+            try
+            {
+                using (var stringReader = new StringReader(xml))
+                using (var xmlReader = XmlReader.Create(stringReader, settings))
+                {
+                    var doc = new XmlDocument { XmlResolver = null };
+                    doc.Load(xmlReader);
+                    if (doc.DocumentElement != null)
+                    {
+                        return doc.DocumentElement.NamespaceURI;
+                    }
+                }
             }
+            catch (XmlException) { }
 
             return null;
         }
@@ -478,7 +500,7 @@ internal static class Version12
 
             public static bool Match(string ns)
             {
-                return ns == Devices || ns == Error || ns == Streams;
+                return ns == Assets || ns == Devices || ns == Error || ns == Streams;
             }
         }
 

tests/MTConnect.NET-Common-Tests/V2_6_V2_7/V2_7DataItemTypeTests.cs

@@ -49,7 +49,7 @@ public void V2_7_DataItem_constructs_with_correct_metadata(
             // surfaces as a clear NUnit failure with the offending type name
             // rather than a bare MissingMethodException.
             object? instance = null;
-            Assert.DoesNotThrow(() => instance = Activator.CreateInstance(dataItemType),
+            Assert.DoesNotThrow((Action)(() => instance = Activator.CreateInstance(dataItemType)),
                 $"{dataItemType.Name} should have a public parameterless constructor");
             Assert.That(instance, Is.Not.Null);
             Assert.That(instance, Is.InstanceOf<DataItem>());