Skip to content

fix(common): add IAgentConfiguration.Sender for Header/@sender #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ottobolyos wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

fix(common): add IAgentConfiguration.Sender for Header/@sender #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6856874
fix(common): make Header/@sender authorable via IAgentConfiguration.S…
ottobolyos Aug 16, 2026
c4958f6
test(common-tests): pin JSON + YAML round trip and defaults for Agent…
ottobolyos Aug 16, 2026
011fb42
test(integration): pin HTTP Probe end-to-end for AgentConfiguration.S…
ottobolyos Aug 16, 2026
5f3b747
docs(common): regenerate reference/configuration.md to include Sender
ottobolyos Aug 16, 2026
04ae9f2
test(common,integration): widen AgentConfiguration.Sender coverage ac…
ottobolyos Aug 16, 2026
099c984
test(common-tests): resolve CS8600 nullable warning on null-configura…
ottobolyos Aug 16, 2026
309fd62
fix(agent-sender): drop dead null-check on ctor sender-seed guard
ottobolyos Aug 19, 2026
df786b2
docs(integration-tests): correct AgentSenderAllEndpoints xml doc
ottobolyos Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/reference/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Configuration for an MTConnect Agent
| `ignoreTimestamps` | `IgnoreTimestamps` | `bool` | Overwrite timestamps with the agent time. This will correct clock drift but will not give as accurate relative time since it will not take into consideration network latencies. This can be overridden on a per adapter basis. |
| `inputValidationLevel` | `InputValidationLevel` | `InputValidationLevel` | Gets or Sets the default Input (Observation or Asset) validation level. 0 = Ignore, 1 = Warning, 2 = Remove, 3 = Strict |
| `observationBufferSize` | `ObservationBufferSize` | `uint` | The maximum number of Observations the agent can hold in its buffer |
| `sender` | `Sender` | `string` | The value emitted as the <c>Header/@sender</c> attribute on MTConnect response documents (see MTConnect Part 1 §7). When null or empty, <see cref="MTConnect.Agents.MTConnectAgent"/> falls back to <see cref="System.Net.Dns.GetHostName"/>. |
| `timezoneOutput` | `TimeZoneOutput` | `string` | Sets the TimeZone to use when timestamps are output from the Agent |

### `DataSourceConfiguration`
Expand Down Expand Up @@ -206,6 +207,7 @@ Configuration for an MTConnect Agent
| `inputValidationLevel` | `InputValidationLevel` | `InputValidationLevel` | Gets the default Input (Observation or Asset) validation level. 0 = Ignore, 1 = Warning, 2 = Remove, 3 = Strict |
| `observationBufferSize` | `ObservationBufferSize` | `uint` | The maximum number of Observations the agent can hold in its buffer |
| `path` | `Path` | `string` | The file system path the configuration was loaded from, used as the default target when the configuration is saved back to disk. |
| `sender` | `Sender` | `string` | The value emitted as the <c>Header/@sender</c> attribute on MTConnect response documents (see MTConnect Part 1 §7). When null or empty, <see cref="MTConnect.Agents.MTConnectAgent"/> falls back to <see cref="System.Net.Dns.GetHostName"/>. |
| `timeZoneOutput` | `TimeZoneOutput` | `string` | Sets the TimeZone to use when timestamps are output from the Agent |

### `IDataSourceConfiguration`
Expand Down
2 changes: 2 additions & 0 deletions libraries/MTConnect.NET-Common/Agents/MTConnectAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,8 @@ public MTConnectAgent(
_uuid = !string.IsNullOrEmpty(uuid) ? uuid : Guid.NewGuid().ToString();
_instanceId = instanceId > 0 ? instanceId : CreateInstanceId();
_configuration = configuration != null ? configuration : new AgentConfiguration();
if (!string.IsNullOrEmpty(_configuration.Sender))
_sender = _configuration.Sender;
_information = new MTConnectAgentInformation(_uuid, _instanceId, _deviceModelChangeTime);
_deviceModelChangeTime = deviceModelChangeTime;
_mtconnectVersion = _configuration != null && _configuration.DefaultVersion != null ? _configuration.DefaultVersion : MTConnectVersions.Max;
Expand Down
6 changes: 6 additions & 0 deletions libraries/MTConnect.NET-Common/Configurations/AgentConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ public class AgentConfiguration : IAgentConfiguration
[YamlIgnore]
public string Path { get; set; }

/// <summary>
/// The value emitted as the <c>Header/@sender</c> attribute on MTConnect response documents (see MTConnect Part 1 §7). When null or empty, <see cref="MTConnect.Agents.MTConnectAgent"/> falls back to <see cref="System.Net.Dns.GetHostName"/>.
/// </summary>
[JsonPropertyName("sender")]
public string Sender { get; set; }


/// <summary>
/// The maximum number of Observations the agent can hold in its buffer
Expand Down
5 changes: 5 additions & 0 deletions libraries/MTConnect.NET-Common/Configurations/IAgentConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ public interface IAgentConfiguration
/// </summary>
string Path { get; }

/// <summary>
/// The value emitted as the <c>Header/@sender</c> attribute on MTConnect response documents (see MTConnect Part 1 §7). When null or empty, <see cref="MTConnect.Agents.MTConnectAgent"/> falls back to <see cref="System.Net.Dns.GetHostName"/>.
/// </summary>
string Sender { get; }


/// <summary>
/// The maximum number of Observations the agent can hold in its buffer
Expand Down
Loading