Allow explicitly configuring git binary paths#8
Open
662a34 wants to merge 1 commit into
Open
Conversation
Owner
|
Hi, thanks for your PR! The idea is great, unfortunately it seems that your current implementation breaks on my setup. I think that on windows the git executable also contains the lfs feature, which means that moving the "lfs" string from the arguments list to the process name breaks the execution of the command ("git lfs" application can't be found). I'm not sure how to fix it while retaining the same functionality for you, but if you want to submit a new request I'd be happy to try it out :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be configured by starting Unity with a different
PATH, but since it's just this plugin calling those binaries, this felt cleaner.Found when running the plugin on my run-of-the-mill mac setup with git-lfs installed per user via homebrew.