fix: bump minimum Flutter SDK to 3.27.0 to fix TapRegionUpCallback not found ( #227, #229)#234
Open
mem-5514-tahara wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Tkko 👋 Thanks again for your continuous work on this package!
I'm submitting this PR to fix the compilation issues reported by users on older Flutter versions.
Problem
Users on Flutter 3.24.x and earlier encounter a compile-time error when using this package:
Root Cause
TapRegionUpCallbackandEditableText.onTapUpOutsidewere introduced in Flutter 3.27.0 via flutter/flutter#156110 — merged on 2024-10-21, included in the Flutter 3.27.0 stable release (tagged 2024-12-10).The
pubspec.yamlSDK constraint wasflutter: ">=3.7.0", which allowed users on older Flutter versions to install the package and hit this compile error at build time.Affected code
lib/src/pinput.dartfinal TapRegionUpCallback? onTapUpOutside;lib/src/pinput_state.dartonTapUpOutside: widget.onTapUpOutside,pubspec.yamlflutter: ">=3.7.0"← too permissiveFix
Raise the minimum Flutter SDK constraint to match the version that introduced the type:
Users on incompatible Flutter versions will now receive a clear version conflict message from the package resolver instead of an opaque compile-time type error.
Bumping the minimum Flutter SDK constraint from 3.7.0 to 3.27.0 is a significant jump. While it correctly reflects the required framework APIs, it acts as a breaking change for users who are still on older Flutter versions.
Depending on your versioning strategy, you might want to consider publishing this change as a major version bump to adhere to semantic versioning and avoid unexpectedly breaking CI pipelines for existing users.
Alternatives Considered
onTapUpOutsideparameterRelated Issues