Skip to content

♻️ Refactor WSIReader.open#1092

Open
shaneahmed wants to merge 5 commits into
developfrom
restructure-wsireader-open
Open

♻️ Refactor WSIReader.open#1092
shaneahmed wants to merge 5 commits into
developfrom
restructure-wsireader-open

Conversation

@shaneahmed

Copy link
Copy Markdown
Member
  • Move WSIReader.open and all try_* functions to factory.py
  • WSIReader then imports lazily open_wsi from factory.py.
  • Move all is_* functions to detection.py
  • Move WSIReaderParams to types.py
  • Move WSIReader staticmethods for validating image read to factory.py

- Move `WSIReader.open` and all `try_*` functions to `factory.py`
- WSIReader then imports lazily `open_wsi` from `factory.py`.
- Move all `is_*` functions to `detection.py`
- Move `WSIReaderParams` to `types.py`
@shaneahmed shaneahmed requested a review from measty July 3, 2026 14:59
@shaneahmed shaneahmed self-assigned this Jul 3, 2026
@shaneahmed shaneahmed added this to the Release v2.2.0 milestone Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.90110% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.88%. Comparing base (2ee33aa) to head (6f8fa3d).

Files with missing lines Patch % Lines
tiatoolbox/wsicore/wsireader/detection.py 97.67% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1092   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files           86       89    +3     
  Lines        11661    11675   +14     
  Branches      1531     1531           
========================================
+ Hits         11648    11662   +14     
  Misses           7        7           
  Partials         6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant