Show/hide Copy Page to Clipboard button based on current page#130
Merged
Conversation
Added BooleanToVisibilityConverter to MainWindow.xaml and bound the Copy to Clipboard button's Visibility to a new ShowCopyButton property in NavigationViewModel. ShowCopyButton is now updated by navigation logic to hide the button on Settings and About pages, and show it elsewhere.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WPF UI to only display the “Copy Page to Clipboard” button when the currently selected navigation page supports page copying, by introducing a ShowCopyButton viewmodel property and binding the button’s Visibility to it.
Changes:
- Added
ShowCopyButtontoNavigationViewModeland update it during navigation to hide the copy button on Settings/About pages. - Added a
BooleanToVisibilityConverterresource and bound the copy button’sVisibilitytoShowCopyButtoninMainWindow.xaml. - Fixed clipboard behavior to return early for unsupported viewmodels (avoids continuing into the copy pipeline after reporting “invalid”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TimVer/ViewModels/NavigationViewModel.cs | Adds and updates ShowCopyButton based on NavPage during navigation. |
| TimVer/MainWindow.xaml | Binds the copy button visibility to the new ShowCopyButton property via BooleanToVisibilityConverter. |
| TimVer/Helpers/ClipboardHelper.cs | Returns immediately on unsupported pages after notifying the user, preventing further copy attempts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
BooleanToVisibilityConvertertoMainWindow.xamland bound the Copy to Clipboard button's Visibility to a newShowCopyButtonproperty inNavigationViewModel.ShowCopyButtonis now updated by navigation logic to hide the button on Settings and About pages and show it elsewhere.