Several instances of .clone() removed.#805
Merged
Merged
Conversation
Replaces a clone per capability drop with mem::replace against T::minimum(); relevant for timestamp types with allocations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Resolves the in-code TODO: cloning toured a spurious increment and decrement through progress tracking per delivered notification. The available collection is a heap, so swap_remove's order disruption is harmless. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ChangeBatch::into_inner yields a SmallVec, which to_vec element-copies. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The puller yields an owned, already deserialized message, so we may drain it rather than clone each update. The comment now records that a zero-copy receive path would hand back a borrowed view, returning this to clones. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The operator core never reads its summary again; cloning retained a copy inside the boxed schedulable for the dataflow's lifetime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Internal capability updates moved their freshly drained time already in the consumed case; do the same for internals, and let the final edge of the produceds fan-out take the time by move. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PerOperatorState::internal_summary is never read after graph assembly; moving it out avoids cloning every operator's connectivity and releases the retained copies for the dataflow's lifetime. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
frankmcsherry
force-pushed
the
clone_nips
branch
from
0bf556e to
d271ad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.