Remove the enter_at trace wrapper - #822
Merged
Merged
Conversation
Nothing calls `Arranged::enter_at` any longer. The dogs3 delta query encoded its alt/neu ordering by entering traces at data-dependent times; `half_join2` now takes a comparison closure instead, which leaves the wrapper without a consumer. The wrapper was also the only one to name cursor data types. Its logic closure took a key, a value, and a time, where `enter` and `frontier` reason only about times and forward keys and values verbatim. Removing it leaves the remaining wrappers cursor-oblivious in their semantics, so a non-cursor framework can implement them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
enter_attrace wrapper, which has a few problematic characteristics. It carries a closure and is not purely data, meaning it interops only with certain Rust types and cannot cross certain abstraction boundaries. It also requires cursor type knowledge for the arguments to the closure (i.e. keys and values).The repository does not use the wrapper, nor does Materialize. It can certainly be added back, but for the moment it is in the way of reorienting the codebase away from cursors as a central concept, and having done that we can imagine how to add it back in once we understand the intent and how best to accommodate it.