chore: fix value-range validation with null values#2300
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a failure in value-range validation when a @ValueRangeProvider returns a SortedSet implementation (such as TreeSet) that may throw when contains(null) is invoked, and adds a regression test to cover the scenario.
Changes:
- Add a new list-variable test domain where the entity provides a
TreeSet-backed value range (SortedSet). - Add a regression test to ensure solving works when the entity-provided value range is a
TreeSet. - Adjust set-based value-range null validation logic in
AbstractFromPropertyValueRangeDescriptor.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/main/java/ai/timefold/solver/core/impl/domain/valuerange/descriptor/AbstractFromPropertyValueRangeDescriptor.java | Tweaks null-element validation for Set-backed value ranges to avoid contains(null) for SortedSet. |
| core/src/test/java/ai/timefold/solver/core/impl/solver/DefaultSolverTest.java | Adds a regression test that solves a problem where the entity value range is a TreeSet. |
| core/src/test/java/ai/timefold/solver/core/testdomain/list/valuerange/unassignedvar/sortedset/TestdataListUnassignedEntityProvidingSortedSetEntity.java | Introduces a planning entity whose value range provider returns a SortedSet (TreeSet). |
| core/src/test/java/ai/timefold/solver/core/testdomain/list/valuerange/unassignedvar/sortedset/TestdataListUnassignedEntityProvidingSortedSetSolution.java | Introduces a planning solution wiring the new entity and generating a minimal problem instance. |
triceo
reviewed
May 11, 2026
Collaborator
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Not sure about this one.
triceo
approved these changes
May 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.