fix: sanitize LLM errors and clean up low-priority findings - #58
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2b82dbd11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zusammenfassung
Folge-PR zu #57 (Restpunkte aus dem Sicherheitsaudit nach PR #56):
sanitize_external_error()bereinigt: Steuerzeichen entfernt, bekannte Secret-Muster (Bearer-Token inkl. Unicode-verschleierter Trennzeichen,sk--Keys,api_key/token/secret/password-Zuweisungen, URL-Credentials) maskiert, auf 240 Zeichen begrenzt. Der vollständige Rohtext bleibt ausschließlich im DEBUG-Log.app/i18n.pyvon ASCII-Umschreibungen (verfuegbar,bestaetigt,unterstuetzt,zusammengefuehrt,Moechtest) auf echte Umlaute korrigiert. Keys und Platzhalter unverändert._is_terminal_active()inapp/paste_service.pyentfernt (nur noch von eigenen Tests genutzt, Produktionspfad nutzt die Logik bereits inline in_ydotool_paste).Verifikation
QT_QPA_PLATFORM=offscreen WHISPER_GUI_TESTS=1 .venv/bin/python -m pytest tests/ -q→ 588 passed, 2 skipped, 0 failedgit diff --check origin/main...HEAD→ sauberNicht im Scope
README.de.md— erfordert reale GUI-Screenshot-Aufnahme, bleibt offener manueller Punkt.Kein Merge durch diesen PR-Ersteller-Workflow — Merge-Entscheidung bei Tim.