Skip to content

docs: fix typos - #893

Merged
jdblischak merged 2 commits into
TileDB-Inc:mainfrom
jeis4wpi:main
Aug 20, 2026
Merged

docs: fix typos#893
jdblischak merged 2 commits into
TileDB-Inc:mainfrom
jeis4wpi:main

Conversation

@jeis4wpi

Copy link
Copy Markdown
Contributor

docs: fix typos

Does this help?

Signed-off-by: John E <jeis4wpi@outlook.com>

@jdblischak jdblischak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeis4wpi thanks for the PR to improve our docs!

Are you familiar with how to document R packages with {roxygen2} and {devtools}? If yes, please run devtools::document() to update the files in man/. If not, I can do this step for you.

@jeis4wpi

Copy link
Copy Markdown
Contributor Author

Happy to push the docs devtools::document() ?

Signed-off-by: John E <jeis4wpi@outlook.com>
@jeis4wpi

Copy link
Copy Markdown
Contributor Author

Hi @jdblischak
do the generated man .Rd files look okay?

@jdblischak jdblischak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeis4wpi! Changes look good. Now we just need the CI jobs to pass (though the Windows builds are expected to fail, so don't worry about them)

@jdblischak
jdblischak merged commit e05cd9f into TileDB-Inc:main Aug 20, 2026
5 of 7 checks passed
@cgiachalis

cgiachalis commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@jdblischak , @ihnorton

That's interesting that this PR got merged so fast whereas this #855 (doc fixes only) is pending review for months... (almost a year)

Note that the same author (or his AI agent ) introduces unnecessary changes or new errors in other R repos (r-lib/mirai#644, r-lib/nanonext#344)

@jdblischak

Copy link
Copy Markdown
Collaborator

That's interesting that this PR got merged so fast whereas this #855 (doc fixes only) is pending review for months... (almost a year)

@cgiachalis thanks for bringing your PR to my attention. I understand your frustration. I met no offense. I wasn't watching this repo as closely when you submitted your PR last year. I approved and merged it in 4244a1d. Thanks again for your many suggestions and contributions!

@cgiachalis

Copy link
Copy Markdown
Contributor

No worries and thanks for your prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants