ci: publish released MWS images to GHCR - #137
Open
linonetwo wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the container build and CI/CD so MultiWikiServer images are produced from published releases (or a manual dispatch) and pushed to GHCR with only an immutable @tiddlywiki/mws version tag (no main/latest).
Changes:
- Docker image now installs a single exact
@tiddlywiki/mwsversion (viaMWS_VERSIONbuild arg) and runsmws update-tiddlywikiat build time, matching thenpm init @tiddlywiki/mwsinstance template. - Adds a GitHub Actions workflow that builds on PRs (no publish) and publishes on GitHub Release
publishedevents (or manual dispatch) after verifying the npm version exists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Dockerfile |
Pins the installed @tiddlywiki/mws version via build arg, aligns instance-data format with the template, and runs mws update-tiddlywiki during image build. |
.github/workflows/publish-container.yml |
Introduces PR build + release/manual publish workflow to GHCR using an immutable version tag. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+51
to
+55
| - name: Check out release source | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.release.tag_name || github.sha }} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #134 with a release-based container workflow.
This does not build production images from
mainand does not install@latest:npm init @tiddlywiki/mws: it uses the0.2.0instance-data format, installs one exact published@tiddlywiki/mwsversion, and runsmws update-tiddlywikiwhile building the image.npm installruns, so an Alpine build can compile a dependency when a prebuilt binary is unavailable.ghcr.io/tiddlywiki/multiwikiserver:0.2.4; the workflow deliberately does not publishmainorlatest.The existing Docker Compose volume contract is unchanged: only
/data/storeis mounted. This PR does not impose my Kubernetes-specific full-/datalayout.