test(e2e): publish shared local Playwright suite - #241
Merged
Conversation
Deploying markdownviewer with
|
| Latest commit: |
7f5fd89
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://599edce8.markdownviewer.pages.dev |
| Branch Preview URL: | https://agent-publish-playwright-tes.markdownviewer.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 43 out of 45 changed files in this pull request and generated no new comments.
Suppressed comments (2)
tests/e2e/smoke.spec.js:11
- The smoke test spawns the static build check via execFileSync('node', ...). Relying on a
nodebinary in PATH can fail in constrained CI/sandbox environments; using process.execPath ensures the same Node runtime running the tests is used.
test('static build smoke check passes', () => {
const output = execFileSync('node', ['tests/helpers/static-build-check.mjs'], {
cwd: process.cwd(),
encoding: 'utf8'
});
tests/helpers/static-server.mjs:38
- resolveRequestPath() calls decodeURIComponent() on the URL pathname; malformed percent-encoding (e.g., "/%E0%A4%A") will throw and crash the static server process. Treat decode failures as a forbidden path (return null) so the server responds 403/404 instead of exiting.
ThisIs-Developer
marked this pull request as ready for review
August 11, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tests/README.mdandwiki/Contributing.md.nvmrcto pin Node.js 22 for reproducible local contributor installsvercel.jsonto preserve the existing root-served static deployment after introducing the rootpackage.jsonLocal-only testing policy
This PR intentionally does not add a GitHub Actions workflow for Playwright. Contributors run the relevant checks locally before requesting review or merging. Playwright reports and failure artifacts remain local and ignored by Git.
Why
The contributing guide advertised root
npm run buildandnpm run test:e2ecommands, but the root package, Playwright configuration, and tests were excluded from version control. A fresh clone therefore could not run the maintainer's local workflow. This publishes that workflow for contributors without adding remote test execution.Fixes #240.
Local validation
npm cinpm audit --audit-level=high— 0 vulnerabilitiesnpm run build— passednpm test— 109/109 Chromium tests passednpm run test:e2e:cross-browser— 9/9 smoke tests passed across Chromium, Firefox, and WebKitnpm run buildandnpm run test:e2e:smoke— 3/3 passedgit diff --check— passed