Skip to content

fix(pdf): fix page breaks and element scaling for PDF export (fixes #166) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThisIs-Developer merged 11 commits into from
Jun 10, 2026
Merged

fix(pdf): fix page breaks and element scaling for PDF export (fixes #166) #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d4143f9
fix(pdf): fix page breaks and element scaling for PDF export (fixes #…
ThisIs-Developer Jun 8, 2026
c4b41bc
fix(pdf): fix text slicing, table pagination and page break layout ov…
ThisIs-Developer Jun 9, 2026
aac5803
fix(pdf): resolve oversized graphics page gaps by physically scaling …
ThisIs-Developer Jun 9, 2026
7e6f91b
fix(pdf): resolve text slicing, diagram page breaks, and layout gaps …
ThisIs-Developer Jun 9, 2026
2795efa
fix(pdf): serialize rendered Mermaid SVGs to base64 images for physic…
ThisIs-Developer Jun 9, 2026
9701ff7
fix(pdf): enforce 20% page safety zone, wait for images, and use phys…
ThisIs-Developer Jun 9, 2026
809affc
fix(pdf): resolve MathJax double-scaling and await webfonts loading d…
ThisIs-Developer Jun 9, 2026
9afe919
fix(pdf): fix Mermaid svg-to-img selector target and implement headin…
ThisIs-Developer Jun 9, 2026
e94d24e
fix(pdf): resolve margin-collapse layout shifting, keep-with-next pos…
ThisIs-Developer Jun 10, 2026
5043e4e
fix(pdf): resolve blockquote callout splitting and margin-collapse pa…
ThisIs-Developer Jun 10, 2026
70915f6
fix(pdf): resolve blockquote alerts and nested table list splitting v…
ThisIs-Developer Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,012 changes: 1,012 additions & 0 deletions MARKETING_AND_COMMUNITY_OUTREACH.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion desktop-app/resources/js/preview-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ function ensureLibraries(urls) {
}

function isSegmentedPreviewSafe(markdown) {
if (/^---\r?\n[\s\S]*?\r?\n---(?:\r?\n|$)/.test(markdown)) return false;
if (/^\s*---\r?\n[\s\S]*?\r?\n---(?:\r?\n|$)/.test(markdown)) return false;
if (/^\[[^\]\n]+\]:\s+\S+/m.test(markdown)) return false;
if (/\[\^[^\]\n]+\]/.test(markdown)) return false;
if (/\n:[ \t]+/.test(markdown)) return false;
Expand Down
847 changes: 633 additions & 214 deletions desktop-app/resources/js/script.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added exported_document.pdf
View file
Open in desktop
Binary file not shown.
75 changes: 75 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"dependencies": {
"playwright": "^1.60.0"
},
"devDependencies": {
"@playwright/test": "^1.60.0"
}
}
2 changes: 1 addition & 1 deletion preview-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ function ensureLibraries(urls) {
}

function isSegmentedPreviewSafe(markdown) {
if (/^---\r?\n[\s\S]*?\r?\n---(?:\r?\n|$)/.test(markdown)) return false;
if (/^\s*---\r?\n[\s\S]*?\r?\n---(?:\r?\n|$)/.test(markdown)) return false;
if (/^\[[^\]\n]+\]:\s+\S+/m.test(markdown)) return false;
if (/\[\^[^\]\n]+\]/.test(markdown)) return false;
if (/\n:[ \t]+/.test(markdown)) return false;
Expand Down
Loading
Loading