Rework PDF export engine#164
Closed
ThisIs-Developer wants to merge 1 commit into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsPDF + html2canvasexporter as a compatibility fallback./libsassets.Why
The previous PDF exporter captured the entire document into one large canvas and sliced it into PNG-backed PDF pages. That approach was slow for large documents, memory-heavy, and prone to layout splits.
The new default path lets the browser/desktop print engine handle pagination, which should be much faster and produce more professional PDFs with selectable text and better layout behavior.
Validation
git diff --checknode --check script.jsnode --check preview-worker.jsnode --check desktop-app/resources/js/script.jsnode --check desktop-app/prepare.js