fix(CodeWebView): guard external-link launch with try/catch#446
Open
jim-daf wants to merge 1 commit into
Open
Conversation
CodeWebView.shouldOverrideUrlLoading routes tapped links out via the startActivity helper, which delegates to AppOpener.launchUrl. The Custom Tabs path inside AppOpener calls customTabsIntent.launchUrl without a try/catch, so if the chosen custom-tabs package is uninstalled between CustomTabsHelper.getBestPackageName and that launchUrl, the exception propagates back through shouldOverrideUrlLoading and the WebView's host activity crashes mid-tap. The non-Custom-Tabs path (openInBrowser) already shows a fallback Toast, so the matching guard belongs at the helper that fans both paths out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #445.
CodeWebView.startActivity(Uri)routes any tapped link out of the code-preview WebView throughAppOpener.launchUrl, which on the Custom Tabs path callscustomTabsIntent.launchUrl(context, Uri.parse(url)). If the chosen custom-tabs package is uninstalled betweenCustomTabsHelper.INSTANCE.getBestPackageName(context)and thislaunchUrl, the latter raisesActivityNotFoundException. The exception propagates all the way back throughshouldOverrideUrlLoadingand the WebView's host activity crashes mid-tap.openInBrowser(the non-Custom-Tabs path) already shows a fallback Toast, so the equivalent guard belongs at the helper:The happy path (URL with a viewer installed) is unchanged.