Repository navigation
Keep the home HA address out of the cloud page and test fixtures - #77
Conversation
…et IP from tests The /cloudcar setup steps printed the Mini's home LAN address from source. They now show the configured ha.url (escaped). The preflight test fixtures used a real tailnet address; they now use 100.64.0.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25ec94e95d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from carwatch import mercedesme as _mm | ||
| return self._send(200, CLOUDCAR_PAGE.replace("__HA_URL__", escape(_mm._ha_url()))) |
There was a problem hiding this comment.
If the optional Mercedes provider failed to import during startup, main() deliberately catches that failure so the dashboard remains available and the cloud UI can report no_provider; this unguarded retry instead raises while handling /cloudcar, leaving that setup page without an HTTP response. Obtain the URL without importing the failed provider, or catch the import/config error and serve the page with an unavailable-state placeholder.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
/cloudcarsetup steps printed the Mini's home LAN address from source. They now show the configuredha.url(viamercedesme._ha_url(), HTML-escaped).tests/test_preflight.pyused a real tailnet address in its fixtures; replaced with100.64.0.10.Tests:
python3 -m unittest discover -s tests227 run, OK (1 skipped).Left in place on purpose:
carwatch/mercedesme.py_DEFAULT_URLstill holds the home LAN address. It is the fallback deployed devices use when neither~/.carwatch/ha-url,CARWATCH_HA_URLnorha.urlin config is set, so removing it could silently break the Mercedes cloud page on an installed device. Removing it is safe once each device hasha.urlset. The address also remains in git history (private range, not reachable from outside).Other private-range addresses in the repo are vendor defaults (OBD dongle 192.168.1.254, dashcam 192.168.1.1) or documentation, and stay.
🤖 Generated with Claude Code