fix(memory): complete provider cancellation#1977
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesCaller abort signals are added to text-generation contracts and forwarded through memory bindings, presenter APIs, provider implementations, AI SDK transports, ACP prompt flows, Copilot device flow, TTS, image, and video requests. Tests cover propagation, timeout composition, cleanup, prompt settlement, and memory capacity release. Cancellation propagation
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant MemoryProviderGateway
participant MemoryProviderBindings
participant LLMProviderPresenter
participant Provider
participant Transport
MemoryProviderGateway->>MemoryProviderBindings: pass AbortSignal
MemoryProviderBindings->>LLMProviderPresenter: generateText(options.signal)
LLMProviderPresenter->>Provider: forward provider options
Provider->>Transport: use combined or relayed abort signal
Transport-->>Provider: settle with cancellation reason
Provider-->>MemoryProviderGateway: settle provider promise
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/main/presenter/acpProvider.test.ts (1)
4-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMove this suite to the mirrored provider test path.
The source is
src/main/presenter/llmProviderPresenter/providers/acpProvider.ts, so this suite should live attest/main/presenter/llmProviderPresenter/providers/acpProvider.test.ts.As per path instructions, “Place main-process Vitest suites under
test/main/and mirror the source layout there.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/main/presenter/acpProvider.test.ts` at line 4, Move the AcpPromptController test suite from its current location to the mirrored path under test/main/presenter/llmProviderPresenter/providers, matching the source location of acpProvider.ts while preserving the suite contents.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/main/presenter/acpProvider.test.ts`:
- Line 4: Move the AcpPromptController test suite from its current location to
the mirrored path under test/main/presenter/llmProviderPresenter/providers,
matching the source location of acpProvider.ts while preserving the suite
contents.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 915b5b5e-6e91-43dc-a55a-ef358ca64b51
📒 Files selected for processing (27)
docs/issues/memory-provider-text-cancellation/spec.mdsrc/main/presenter/agentRuntimePresenter/compactionService.tssrc/main/presenter/githubCopilotDeviceFlow.tssrc/main/presenter/index.tssrc/main/presenter/llmProviderPresenter/aiSdk/runtime.tssrc/main/presenter/llmProviderPresenter/baseProvider.tssrc/main/presenter/llmProviderPresenter/index.tssrc/main/presenter/llmProviderPresenter/providers/acpProvider.tssrc/main/presenter/llmProviderPresenter/providers/aiSdkProvider.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/llmProviderPresenter/providers/ollamaProvider.tssrc/main/presenter/llmProviderPresenter/providers/voiceAIProvider.tssrc/main/presenter/memoryProviderBindings.tssrc/shared/types/presenters/core.presenter.d.tssrc/shared/types/presenters/llmprovider.presenter.d.tstest/main/presenter/acpProvider.test.tstest/main/presenter/agentRuntimePresenter/compactionService.test.tstest/main/presenter/githubCopilotDeviceFlow.test.tstest/main/presenter/llmProviderPresenter.test.tstest/main/presenter/llmProviderPresenter/aiSdkRuntime.test.tstest/main/presenter/llmProviderPresenter/anthropicProvider.test.tstest/main/presenter/llmProviderPresenter/baseProvider.test.tstest/main/presenter/llmProviderPresenter/githubCopilotProvider.test.tstest/main/presenter/llmProviderPresenter/ollamaProviderCancellation.test.tstest/main/presenter/llmProviderPresenter/voiceAIProvider.test.tstest/main/presenter/memoryProviderBindings.test.tstest/main/presenter/memoryProviderGateway.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Tests