Skip to content

feat: feishu thinking reaction#1642

Merged
zhangmo8 merged 1 commit into
devfrom
feishu-bot
May 19, 2026
Merged

feat: feishu thinking reaction#1642
zhangmo8 merged 1 commit into
devfrom
feishu-bot

Conversation

@zhangmo8
Copy link
Copy Markdown
Collaborator

@zhangmo8 zhangmo8 commented May 19, 2026

4d8d42fcac565b3a5bedd99e74b3a3c1

Summary by CodeRabbit

  • New Features
    • Feishu integration now displays a thinking reaction indicator on messages while they are being processed, automatically clearing it upon completion. This provides users with clear visual feedback on processing status.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b111656-ae62-43e4-a7e2-ca8626c99ca5

📥 Commits

Reviewing files that changed from the base of the PR and between f60b8cd and 13c8432.

📒 Files selected for processing (3)
  • src/main/presenter/remoteControlPresenter/feishu/feishuClient.ts
  • src/main/presenter/remoteControlPresenter/feishu/feishuRuntime.ts
  • src/main/presenter/remoteControlPresenter/types.ts

📝 Walkthrough

Walkthrough

The PR adds Feishu message reaction support: a new emoji constant defines the "thinking" reaction type, two client methods enable adding and removing reactions via the Feishu API, and the runtime integrates these to automatically set the reaction before conversation delivery and clear it afterward.

Changes

Feishu Message Reaction Support

Layer / File(s) Summary
Feishu reaction API contract
src/main/presenter/remoteControlPresenter/types.ts, src/main/presenter/remoteControlPresenter/feishu/feishuClient.ts
FEISHU_REMOTE_REACTION_EMOJI constant set to 'THINKING'; addReaction(messageId, emojiType) creates a message reaction and returns the reaction ID; removeReaction(messageId, reactionId) deletes a reaction.
Thinking reaction lifecycle in conversation delivery
src/main/presenter/remoteControlPresenter/feishu/feishuRuntime.ts
Import and use the reaction emoji constant; wrap deliverConversation to set a thinking reaction before delivery and remove it after (in finally); both operations are failure-tolerant with errors logged but not blocking delivery or cleanup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit adds reactions with glee,
'THINKING' thoughts now all can see,
Before delivery starts, the emoji glows bright,
Then vanishes after—a thinking delight! 🐰💭✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: feishu thinking reaction' accurately describes the main change: adding thinking reaction functionality to the Feishu client implementation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feishu-bot

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zhangmo8 zhangmo8 merged commit 7acdd1e into dev May 19, 2026
3 checks passed
@zhangmo8 zhangmo8 deleted the feishu-bot branch May 19, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant