chore: Remove duplicate Terrain definitions#45
Open
Stubbjax wants to merge 1 commit into
Open
Conversation
xezon
reviewed
May 22, 2026
| Class = SAND | ||
| End | ||
|
|
||
| Terrain SandMediumType2 |
There was a problem hiding this comment.
Its removing the duplicate that is better positioned
| Class = DESERT_DRY | ||
| End | ||
|
|
||
| Terrain SandLargeType3Light |
There was a problem hiding this comment.
Its removing the duplicate that is better positioned
| Class = BEACH_TROPICAL | ||
| End | ||
|
|
||
| Terrain SandMediumType13grassy2 |
There was a problem hiding this comment.
This is the wrong one to remove. Class must not be SNOW
| Class = BEACH_TROPICAL | ||
| End | ||
|
|
||
| Terrain SandMediumType13grassy3 |
There was a problem hiding this comment.
This is the wrong one to remove. Class must not be SNOW
|
|
||
| ; URBAN | ||
|
|
||
| Terrain CliffLargeType6 |
| Class = SNOW_FLAT | ||
| End | ||
|
|
||
| Terrain ConcreteMediumType1Snow |
There was a problem hiding this comment.
This one looks better fitting than the other. It is a snow texture.
Contributor
Author
Of course. No behavioural changes are intended at this stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes duplicate
Terraindefinitions. None of the removed definitions were ever presented to the user as they are overwritten by subsequent definitions. The only differences between duplicates is theClassfield.Classes can be audited in a future change if necessary.
Generals
ConcreteType4SandMediumType2SnowType6Zero Hour
Cobble04SandLargeType3LightRocksType6SandMediumType7LightDirtMediumType11RocksMediumType1SandMediumType6SandMediumType13bSandMediumType13cSandMediumType13dSandMediumType13grassy3SandLargeType3GrassySandType4SandMediumType9blueSandMediumType9blue2SandMediumType9blue3SandMediumType9blue4SandMediumType9bSandMediumType13grassy2SandMediumType13grassy3SandMediumType6GrassMediumType22WoodType1GrassMediumType23GrassMediumType10GrassMediumType11bDirtType1DirtMediumType1DirtMediumType5DirtMediumType14DirtMediumType14GrassMediumType37dGrassMediumType37gGrassMediumType7DirtType1DirtType2GrassMediumType1GrassMediumType22DirtMediumType15SnowConcreteMediumType1SnowConcreteType4CliffLargeType7CliffLargeType6CliffLargeType7