You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 26, 2022. It is now read-only.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
Can't convert this to draft, and I guess I still need some time.
Found something: #root needs to be height: 100%.
This should just be mentioned first on the MaterialApp docs. If you want, I can try some different setups (using two MaterialApps, etc).
z-index on the aside is the culprit. Scrollbars don't have z-index (on chrome), so best idea for now:
put margin-left: <scrollbar-width> on the side-menu.
I will push a smaller scrollbar later.
Right now we have another problem:
It's not updating with the new scrollbar, let me see what I can do.
Update: cferdinandi/gumshoe#114 okay, gumshoe apparently only works on the "main scrollbar".
I mean, something like gumshoe which has the option to also specify the container on which scrolls happen would be nice.
We could leave this open until I get the time to find an alternative or anybody has a better idea.
Florian-Schoenherr
changed the title
feat(MaterialApp): theme scrollbars, theme blank
feat(MaterialApp): theme scrollbars
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
squash (next time I will lint before commiting)
Closes: #56