Skip to content

added my name in practice - #12

Open
KrisGod21 wants to merge 1 commit into
TheCodeVerseHub:mainfrom
KrisGod21:my-first-change
Open

added my name in practice#12
KrisGod21 wants to merge 1 commit into
TheCodeVerseHub:mainfrom
KrisGod21:my-first-change

Conversation

@KrisGod21

Copy link
Copy Markdown

What changed?

I replaced the name in the practice file with mine.

Why?

This change was made to practice the GitHub fork, clone, commit, push, and pull request workflow.

How to test

  1. Open the modified file.
  2. Verify that the placeholder name has been replaced with "Krishna Sharma" .

Provide copy/paste commands and expected output.

Checklist

  • I linked an issue or explained why not
  • I added/updated docs for user-facing changes
  • I added/updated tests (or explained why not)
  • [x ] I did not commit secrets (tokens, .env, keys)
  • [ x] CI should pass for this PR

Screenshots (optional)

If this changes UI/UX, include before/after.
Provide copy/paste commands and expected output.

Checklist

  • I linked an issue or explained why not
  • I added/updated docs for user-facing changes
  • I added/updated tests (or explained why not)
  • I did not commit secrets (tokens, .env, keys)
  • CI should pass for this PR

Screenshots (optional)

If this changes UI/UX, include before/after.

Comment thread practice/add-your-name.md
- `- Your Name (GitHub: @username)`

## Add your name here
- shrutinath(@shrutinath93)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee, but we don't actually want to remove other people's names, just add your name under the other person's name, not replace it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants