feat: add free-fall motion calculations#233
Open
nickzerjeski wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
feat: add free-fall motion calculations#233nickzerjeski wants to merge 2 commits intoTheAlgorithms:masterfrom
nickzerjeski wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new maths helper for free-fall motion calculations (constant acceleration under gravity), addressing Issue #194 by providing both “distance from time” and “time from distance” APIs with basic domain validation.
Changes:
- Added
FreeFallDistance.distance(time:, gravity:)implementingd = 0.5 * g * t^2 - Added
FreeFallDistance.time(distance:, gravity:)implementingt = sqrt(2d / g) - Added Minitest coverage for the core formulas and negative time/distance validation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| maths/free_fall_distance.rb | Introduces free-fall distance/time helpers, gravity constant default, and domain validation. |
| maths/free_fall_distance_test.rb | Adds unit tests validating the formulas and negative-input error behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
ruby maths/free_fall_distance_test.rbFixes #194