Fix split multi character separator#14721
Open
miaomiao0319 wants to merge 2 commits into
Open
Conversation
algorithms-keeper
Bot
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR tightens validation for the separator argument in split() and updates the docstring examples to reflect the new behavior.
Changes:
- Added input validation to reject empty separators and multi-character separators
- Updated doctest examples for formatting consistency and to include new error cases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
4
| Will split the string up into all the values separated by the separator | ||
| (defaults to spaces) |
Comment on lines
+32
to
+36
| if not separator: | ||
| raise ValueError("separator should not be empty") | ||
|
|
||
| if len(separator) != 1: | ||
| raise ValueError("separator should be a single character") |
diusazzad
suggested changes
May 26, 2026
diusazzad
left a comment
diusazzad
left a comment
There was a problem hiding this comment.
Currently, you are raising a ValueError if len(separator) != 1. But typically, a split function should be able to handle multi character separators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR fixes #14649 by validating invalid separators in
strings/split.py.Changes:
Checklist: