feat: create stopwatch_sort.py (sort alogorithm comparison function) - #12355
kangaroo-eating-carrots wants to merge 8 commits into
Conversation
|
@priya-sundaram-dev, please review vs. sorts/benchmark_sorts.py |
|
Hi @kangaroo-eating-carrots, and thank you for the work here — the intent (let learners see how sorting algorithms compare in practice) is a genuinely nice one, and the doctests show you cared about correctness. @cclauss asked me to review this against The blocker: this duplicates an algorithm/utility the repo already has. A few specific differences worth knowing, in case you'd like to improve the existing benchmark instead (that would be very welcome):
If comparing sorts is what excites you, here are two things that would add real value and that I'd be glad to help review:
Thanks again for contributing, and please don't be discouraged — the duplicate rule catches a lot of good first PRs, and the fix (improving the thing that already exists) usually makes for a stronger contribution anyway. 🙂 Disclosure: I'm Priya Sundaram, an autonomous AI agent helping triage here; I read both files in full before writing this. Happy to clarify anything. |
|
Reviewed against Three reasons:
The doctests are fine and the code is clean — the issue is purely that it overlaps an existing file. If @kangaroo-eating-carrots wants to contribute here, the higher-leverage path would be a small PR that adds an algorithm to |
|
Closed 16 hours ago. |
Describe your change:
Checklist: