Bump the Gallery manifest in step with the release version - #93
Merged
Conversation
RackStack.psd1 was not in the version-sensitive file list, so its ModuleVersion stayed on 1.122.0 while the rest of the tree moved to 1.122.1. ci.yml's PSGallery step refuses to publish a manifest whose version disagrees with Header.ps1, and it correctly did - but that step runs in the release job, so the GitHub release had already been created, signed, and attested by the time it failed. v1.122.1 therefore reached GitHub Releases but not the Gallery, and the winget, Chocolatey, and retention steps behind it were skipped. - Bump RackStack.psd1 to 1.122.2 alongside every other version touchpoint - Add Run-Tests section 205, asserting that 00-Initialization, Header.ps1, RackStack.ps1, Run-Tests' synopsis, RackStack.psd1, and the changelog all agree on the version, so a mismatch fails PR CI instead of part-way through a release. Verified against the v1.122.1 state: init 1.122.2 with psd1 1.122.0 fails the check. - Add RackStack.psd1 to the section 174 documentation-freshness file list rather than duplicating the count logic. That immediately caught the manifest description advertising 176 CLI actions against a live 201 - a number that ships to the Gallery listing.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
v1.122.1published to GitHub Releases but not to the PowerShell Gallery.RackStack.psd1was not in the version-sensitive file list, so itsModuleVersionstayed on1.122.0while the rest of the tree moved to1.122.1. The Gallery publish step inci.ymlrefuses to push a manifest whose version disagrees withHeader.ps1— that guard is correct and it did its job:The problem is where it fires. That step runs in the release job, so by the time it failed the GitHub release had already been created, signed, attested, and tagged. The steps behind it — winget submission, Chocolatey publish, and the retention rule — were skipped.
Re-running does not help: those steps are gated on
steps.releasecheck.outputs.exists == 'false', andv1.122.1now exists, so they would skip.Fix
Releasing
v1.122.2, which is self-healing — the retention rule collapses all1.122.xreleases to the newest, so this ends with a single release that is correct on every channel.RackStack.psd1bumped to1.122.2in step with every other version touchpoint.Run-Testssection 205 asserts that00-Initialization.ps1,Header.ps1,RackStack.ps1, theRun-Testssynopsis,RackStack.psd1, and the changelog all agree on the version. A mismatch now costs a red check on the pull request instead of a half-published release. Verified against the exact failing state (init 1.122.2+psd1 1.122.0) to confirm it catches the regression rather than passing vacuously.RackStack.psd1added to section 174's documentation-freshness list instead of duplicating the count-derivation logic. That immediately caught the manifest description advertising 176 CLI actions against a live 201 — a stale number that ships to the Gallery listing.local/release-touchpoints.mdandlocal/Validate-Release.ps1(both untracked) were updated to match, so the checklist and the local gate no longer disagree with what CI enforces.Verification
RackStack.psd1 ModuleVersion matches (1.122.2)The two remaining
Validate-Releasefailures (stats footer,no empty version sections) are pre-existing and unrelated — both are stale expectations of a changelog convention abandoned around v1.98, and they fail identically on v1.122.0.Contents
This carries everything in v1.122.1: the self-update integrity fix and the antivirus documentation.